staging: r8188eu: remove state checks in rtw_led_control
authorMartin Kaiser <martin@kaiser.cx>
Sun, 6 Nov 2022 12:48:57 +0000 (13:48 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 8 Nov 2022 15:29:29 +0000 (16:29 +0100)
There's no need to check for bSurpriseRemoved or bDriverStopped in the
rtw_led_control function. This function schedules a delayed worker which
calls SwLedOn or SwLedOff (or the function calls SwLedOff directly).

SwLedOn and SwLedOff check bDriverStopped themselves or they initiate a
USB control transfer via usb_write, where bSurpriseRemoved is checked.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
Link: https://lore.kernel.org/r/20221106124901.720785-6-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/core/rtw_led.c

index ce8de2e..48725ce 100644 (file)
@@ -140,8 +140,7 @@ void rtw_led_control(struct adapter *padapter, enum LED_CTL_MODE LedAction)
        struct registry_priv *registry_par;
        struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
 
-       if ((padapter->bSurpriseRemoved) || (padapter->bDriverStopped) ||
-           (!padapter->hw_init_completed))
+       if (!padapter->hw_init_completed)
                return;
 
        if (!pLed->bRegUseLed)