net/sunrpc: return 0 on attempt to write to "transports"
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 6 Nov 2020 20:39:50 +0000 (15:39 -0500)
committerJ. Bruce Fields <bfields@redhat.com>
Fri, 6 Nov 2020 20:56:18 +0000 (15:56 -0500)
You can't write to this file because the permissions are 0444.  But
it sort of looked like you could do a write and it would result in
a read.  Then it looked like proc_sys_call_handler() just ignored
it.  Which is confusing.  It's more clear if the "write" just
returns zero.

Also, the "lenp" pointer is never NULL so that check can be removed.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
net/sunrpc/sysctl.c

index a18b36b5422d49b278e94793c6653b81fbc7c142..5c9f5bca4d99dccc7d18f624a7b6c684fc437985 100644 (file)
@@ -65,7 +65,7 @@ static int proc_do_xprt(struct ctl_table *table, int write,
        char tmpbuf[256];
        size_t len;
 
-       if ((*ppos && !write) || !*lenp) {
+       if (write || *ppos) {
                *lenp = 0;
                return 0;
        }