sysdeps: assert that log severity is one we expect
authorSimon McVittie <simon.mcvittie@collabora.co.uk>
Tue, 17 Jan 2017 20:54:20 +0000 (20:54 +0000)
committerSimon McVittie <smcv@collabora.com>
Fri, 7 Apr 2017 11:08:16 +0000 (12:08 +0100)
This silences -Wswitch-default.

Based on part of a patch from Thomas Zimmermann.

Signed-off-by: Simon McVittie <smcv@collabora.com>
Reviewed-by: Philip Withnall <withnall@endlessm.com>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=98191

dbus/dbus-sysdeps-unix.c
dbus/dbus-sysdeps-win.c

index 39c1336..8b6ac30 100644 (file)
@@ -4628,7 +4628,7 @@ _dbus_logv (DBusSystemLogSeverity  severity,
             flags = LOG_DAEMON|LOG_CRIT;
             break;
           default:
-            return;
+            _dbus_assert_not_reached ("invalid log severity");
         }
 
       DBUS_VA_COPY (tmp, args);
index e5cab35..5a94eaf 100644 (file)
@@ -3720,6 +3720,7 @@ _dbus_logv (DBusSystemLogSeverity  severity,
      case DBUS_SYSTEM_LOG_WARNING: s = "warning"; break;
      case DBUS_SYSTEM_LOG_SECURITY: s = "security"; break;
      case DBUS_SYSTEM_LOG_FATAL: s = "fatal"; break;
+     default: _dbus_assert_not_reached ("invalid log severity");
    }
 
   if (log_flags & DBUS_LOG_FLAGS_SYSTEM_LOG)