perf dso: Fix /proc/kcore access on 32 bit systems
authorJames Clark <james.clark@arm.com>
Thu, 21 Oct 2021 11:27:00 +0000 (12:27 +0100)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 25 Oct 2021 16:47:42 +0000 (13:47 -0300)
Because _LARGEFILE64_SOURCE is set in perf, file offset sizes can be
64 bits. If a workflow needs to open /proc/kcore on a 32 bit system (for
example to decode Arm ETM kernel trace) then the size value will be
wrapped to 32 bits in the function file_size() at this line:

  dso->data.file_size = st.st_size;

Setting the file_size member to be u64 fixes the issue and allows
/proc/kcore to be opened.

Reported-by: Denis Nikitin <denik@chromium.org>
Signed-off-by: James Clark <james.clark@arm.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lore.kernel.org/lkml/20211021112700.112499-1-james.clark@arm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/dso.h

index 83723ba..011da39 100644 (file)
@@ -193,7 +193,7 @@ struct dso {
                int              fd;
                int              status;
                u32              status_seen;
-               size_t           file_size;
+               u64              file_size;
                struct list_head open_entry;
                u64              debug_frame_offset;
                u64              eh_frame_hdr_offset;