usb: phy: tegra: Fix unnecessary check in tegra_usb_phy_probe()
authorTang Bin <tangbin@cmss.chinamobile.com>
Thu, 28 May 2020 11:47:17 +0000 (19:47 +0800)
committerFelipe Balbi <balbi@kernel.org>
Wed, 24 Jun 2020 06:43:16 +0000 (09:43 +0300)
In the function tegra_usb_phy_probe(), if usb_add_phy_dev() failed,
the return value will be given to err, and if usb_add_phy_dev() succeed,
the return value will be zero. Thus it is unnecessary to repeated check
here.

Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
drivers/usb/phy/phy-tegra-usb.c

index cffe2ac..03a3337 100644 (file)
@@ -1199,11 +1199,7 @@ static int tegra_usb_phy_probe(struct platform_device *pdev)
 
        platform_set_drvdata(pdev, tegra_phy);
 
-       err = usb_add_phy_dev(&tegra_phy->u_phy);
-       if (err)
-               return err;
-
-       return 0;
+       return usb_add_phy_dev(&tegra_phy->u_phy);
 }
 
 static int tegra_usb_phy_remove(struct platform_device *pdev)