fs/ntfs3: uninitialized variable in ntfs_set_acl_ex()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 8 Aug 2022 08:34:41 +0000 (11:34 +0300)
committerKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
Wed, 10 Aug 2022 16:12:58 +0000 (19:12 +0300)
The goto out calls kfree(value) on an uninitialized pointer.  Just
return directly as the other error paths do.

Fixes: 460bbf2990b3 ("fs/ntfs3: Do not change mode if ntfs_set_ea failed")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
fs/ntfs3/xattr.c

index 02f6a933ee79777f364e484b7459282c3dcad897..5bdff12a1232dbcef7ae04e5efd3d91f56034ada 100644 (file)
@@ -568,7 +568,7 @@ static noinline int ntfs_set_acl_ex(struct user_namespace *mnt_userns,
                        err = posix_acl_update_mode(mnt_userns, inode, &mode,
                                                    &acl);
                        if (err)
-                               goto out;
+                               return err;
                }
                name = XATTR_NAME_POSIX_ACL_ACCESS;
                name_len = sizeof(XATTR_NAME_POSIX_ACL_ACCESS) - 1;