projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
7ef9f9a
)
wimax: checking ERR_PTR vs null
author
Dan Carpenter
<error27@gmail.com>
Thu, 22 Apr 2010 09:50:10 +0000
(
02:50
-0700)
committer
Inaky Perez-Gonzalez
<inaky.perez-gonzalez@intel.com>
Tue, 11 May 2010 21:09:10 +0000
(14:09 -0700)
stch_skb is allocated with wimax_gnl_re_state_change_alloc(). That
function returns ERR_PTRs on failure and doesn't return NULL.
Signed-off-by: Dan Carpenter <error27@gmail.com>
net/wimax/stack.c
patch
|
blob
|
history
diff --git
a/net/wimax/stack.c
b/net/wimax/stack.c
index
1ed65db
..
62b1a66
100644
(file)
--- a/
net/wimax/stack.c
+++ b/
net/wimax/stack.c
@@
-315,7
+315,7
@@
void __wimax_state_change(struct wimax_dev *wimax_dev, enum wimax_st new_state)
BUG();
}
__wimax_state_set(wimax_dev, new_state);
- if (
stch_skb
)
+ if (
!IS_ERR(stch_skb)
)
wimax_gnl_re_state_change_send(wimax_dev, stch_skb, header);
out:
d_fnend(3, dev, "(wimax_dev %p new_state %u [old %u]) = void\n",