net: mscc: ocelot: return directly in ocelot_cls_flower_{replace, destroy}
authorVladimir Oltean <vladimir.oltean@nxp.com>
Sat, 29 Feb 2020 14:31:08 +0000 (16:31 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 4 Mar 2020 02:57:29 +0000 (18:57 -0800)
There is no need to check the "ret" variable, one can just return the
function result back to the caller.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Tested-by: Horatiu Vultur <horatiu.vultur@microchip.com>
Reviewed-by: Allan W. Nielsen <allan.nielsen@microchip.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mscc/ocelot_flower.c

index 698e9fe..8993dad 100644 (file)
@@ -192,11 +192,7 @@ int ocelot_cls_flower_replace(struct ocelot *ocelot, int port,
                return ret;
        }
 
-       ret = ocelot_ace_rule_offload_add(ocelot, ace);
-       if (ret)
-               return ret;
-
-       return 0;
+       return ocelot_ace_rule_offload_add(ocelot, ace);
 }
 EXPORT_SYMBOL_GPL(ocelot_cls_flower_replace);
 
@@ -204,16 +200,11 @@ int ocelot_cls_flower_destroy(struct ocelot *ocelot, int port,
                              struct flow_cls_offload *f, bool ingress)
 {
        struct ocelot_ace_rule ace;
-       int ret;
 
        ace.prio = f->common.prio;
        ace.id = f->cookie;
 
-       ret = ocelot_ace_rule_offload_del(ocelot, &ace);
-       if (ret)
-               return ret;
-
-       return 0;
+       return ocelot_ace_rule_offload_del(ocelot, &ace);
 }
 EXPORT_SYMBOL_GPL(ocelot_cls_flower_destroy);