Fix the exception of preference_unset_changed_cb function 91/193391/4
authorHwankyu Jhun <h.jhun@samsung.com>
Tue, 20 Nov 2018 06:03:48 +0000 (15:03 +0900)
committerHwanKyu Jhun <h.jhun@samsung.com>
Tue, 20 Nov 2018 23:30:59 +0000 (23:30 +0000)
If the internal function returns a negative error value,
the preference_unset_changed_cb function also returns the negative error value.

Change-Id: Ifbb6b210e0e0c944883cff02f9d4b980d28f49b5
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
src/preference.c

index 7f84f3057cdc22594d5c8bff700596a8b41a37bd..b075dda0ed4987f1018024643f05ee0b7a84236f 100644 (file)
@@ -1509,9 +1509,14 @@ API int preference_unset_changed_cb(const char *key)
                        LOGE("NO_KEY(0x%08x) : fail to find given key(%s)", PREFERENCE_ERROR_NO_KEY, key);
                        _preference_keynode_free(pKeyNode);
                        return PREFERENCE_ERROR_NO_KEY;
-               } else if (errno != 0) {
-                       strerror_r(errno, err_buf, sizeof(err_buf));
-                       ERR("preference_unset_changed_cb() failed: key(%s) error(%d/%s)", key, errno, err_buf);
+               } else {
+                       if (errno != 0) {
+                               strerror_r(errno, err_buf, sizeof(err_buf));
+                               ERR("preference_unset_changed_cb() failed: key(%s) error(%d:%s)",
+                                               key, errno, err_buf);
+                       } else {
+                               ERR("preference_unset_changed_cb() failed: key(%s)", key);
+                       }
                        _preference_keynode_free(pKeyNode);
                        return PREFERENCE_ERROR_IO_ERROR;
                }