drm: fix device_node_continue.cocci warnings
authorJulia Lawall <julia.lawall@inria.fr>
Sun, 12 Jun 2022 11:02:31 +0000 (13:02 +0200)
committerPaul Kocialkowski <paul.kocialkowski@bootlin.com>
Fri, 24 Jun 2022 15:22:50 +0000 (17:22 +0200)
drivers/gpu/drm/logicvc/logicvc_layer.c:616:2-13: ERROR: probable double put.

 Device node iterators put the previous value of the index variable, so an
 explicit put causes a double put.

Generated by: scripts/coccinelle/iterators/device_node_continue.cocci

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
Acked-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Link: https://patchwork.freedesktop.org/patch/msgid/alpine.DEB.2.22.394.2206121300120.3447@hadrien
drivers/gpu/drm/logicvc/logicvc_layer.c

index 463653b..31c5c42 100644 (file)
@@ -615,8 +615,6 @@ int logicvc_layers_init(struct logicvc_drm *logicvc)
                ret = logicvc_layer_init(logicvc, layer_node, index);
                if (ret)
                        goto error;
-
-               of_node_put(layer_node);
        }
 
        of_node_put(layers_node);