Remove cert-checker dependency 43/105343/1
authorsangwan.kwon <sangwan.kwon@samsung.com>
Fri, 16 Dec 2016 08:25:51 +0000 (17:25 +0900)
committersangwan.kwon <sangwan.kwon@samsung.com>
Fri, 16 Dec 2016 08:25:51 +0000 (17:25 +0900)
[AS-IS]
* cert-checker API is called by cert-svc when ocsp check failed.

[TO-BE]
* cert-checker API should be change to plug-in.
* This is for removing dependency on mobile profile.

Change-Id: I8184367cb89d128391b680fc5d71287db8f5346a
Signed-off-by: sangwan.kwon <sangwan.kwon@samsung.com>
packaging/cert-svc.spec
src/CMakeLists.txt
src/vcore/BaseValidator.cpp

index d35f2a3..fd50ddd 100644 (file)
@@ -30,9 +30,6 @@ Requires: ca-certificates
 Requires: ca-certificates-tizen
 Requires: security-config
 Requires: openssl
-%if "%{?profile}" == "mobile"
-BuildRequires: pkgconfig(cert-checker)
-%endif
 
 %global user_name security_fw
 %global group_name security_fw
@@ -117,11 +114,6 @@ export FFLAGS="$FFLAGS -DTIZEN_EMULATOR_MODE"
          -DCERT_SVC_OLD_DB_PATH=%cert_svc_old_db_path \
          -DUPGRADE_SCRIPT_PATH=%upgrade_script_path \
          -DUPGRADE_DATA_PATH=%upgrade_data_path \
-%if "%{?profile}" == "mobile"
-         -DTIZEN_PROFILE_MOBILE:BOOL=ON \
-%else
-         -DTIZEN_PROFILE_MOBILE:BOOL=OFF \
-%endif
 %if 0%{?certsvc_test_build}
          -DCERTSVC_TEST_BUILD=1 \
          -DCERT_SVC_TESTS=%cert_svc_tests \
index 8589ad6..94a9a59 100644 (file)
 #
 
 ######################### VCORE #########################
-
-IF(TIZEN_PROFILE_MOBILE)
-    ADD_DEFINITIONS("-DTIZEN_PROFILE_MOBILE")
-    SET(LIB_CERT_CHECKER cert-checker)
-ENDIF(TIZEN_PROFILE_MOBILE)
-
 PKG_CHECK_MODULES(VCORE_DEPS
     REQUIRED
     libxml-2.0
@@ -32,7 +26,6 @@ PKG_CHECK_MODULES(VCORE_DEPS
     xmlsec1
     dlog
     libsystemd-journal
-    ${LIB_CERT_CHECKER}
     )
 
 ADD_DEFINITIONS(${VCORE_DEPS_CFLAGS})
index 1c7ac68..e978fb7 100644 (file)
 #include <vcore/SignatureFinder.h>
 #include <vcore/Ocsp.h>
 
-#ifdef TIZEN_PROFILE_MOBILE
-#include <cchecker/ocsp.h>
-#endif
-
 using namespace ValidationCore::CertStoreId;
 
 namespace {
@@ -369,17 +365,6 @@ VCerr BaseValidator::baseCheck(const std::string &contentPath,
                LogInfo("Ocsp unsupported : " << e.DumpToString());
        } catch (const Ocsp::Exception::Base &e) {
                LogInfo("Ocsp check throw exeption : " << e.DumpToString());
-#ifdef TIZEN_PROFILE_MOBILE
-               LogInfo("Launch cert-checker.");
-               try {
-                       if (cchecker_ocsp_request() != 0)
-                               LogError("Load cert-checker failed.");
-               } catch (const std::exception &e) {
-                       LogError("std exception occured while cchecker running : " << e.what());
-               } catch (...) {
-                       LogError("Unknown exception occuured while cchecker running. ");
-               }
-#endif
        } catch (const std::exception &e) {
                LogError("std exception occured : " << e.what());
                return E_SIG_UNKNOWN;
@@ -434,17 +419,6 @@ VCerr BaseValidator::baseCheckList(bool checkOcsp, const UriList &uriList)
                LogInfo("Ocsp unsupported : " << e.DumpToString());
        } catch (const Ocsp::Exception::Base &e) {
                LogInfo("Ocsp check throw exeption : " << e.DumpToString());
-#ifdef TIZEN_PROFILE_MOBILE
-               LogInfo("Launch cert-checker.");
-               try {
-                       if (cchecker_ocsp_request() != 0)
-                               LogError("Load cert-checker failed.");
-               } catch (const std::exception &e) {
-                       LogError("std exception occured while cchecker running : " << e.what());
-               } catch (...) {
-                       LogError("Unknown exception occuured while cchecker running. ");
-               }
-#endif
        } catch (...) {
                LogError("Unknown exception in BaseValidator::checkList");
                return E_SIG_UNKNOWN;