RDMA/hns: Simplify attribute judgment code
authorLang Cheng <chenglang@huawei.com>
Fri, 20 Mar 2020 03:23:35 +0000 (11:23 +0800)
committerJason Gunthorpe <jgg@mellanox.com>
Thu, 26 Mar 2020 19:52:27 +0000 (16:52 -0300)
Combine attribute flags before masking them.

Link: https://lore.kernel.org/r/1584674622-52773-4-git-send-email-liweihang@huawei.com
Signed-off-by: Lang Cheng <chenglang@huawei.com>
Signed-off-by: Weihang Li <liweihang@huawei.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/hns/hns_roce_hw_v2.c

index 94cb298..518a649 100644 (file)
@@ -4281,8 +4281,7 @@ static int modify_qp_rtr_to_rts(struct ib_qp *ibqp,
        }
 
        /* Not support alternate path and path migration */
-       if ((attr_mask & IB_QP_ALT_PATH) ||
-           (attr_mask & IB_QP_PATH_MIG_STATE)) {
+       if (attr_mask & (IB_QP_ALT_PATH | IB_QP_PATH_MIG_STATE)) {
                ibdev_err(ibdev, "RTR2RTS attr_mask (0x%x)error\n", attr_mask);
                return -EINVAL;
        }