elm diskselector: Fixed elm_diskselector_item_selected_set() hanging bug. Patch by...

On Wed, Sep 7, 2011 at 6:51 PM, Hyoyoung Chang <hyoyoung.chang@samsung.com> wrote:
> Dear developers.
>
> This patch is fixing - hangs after using elm_diskselector_item_selected_set.
> Elm_diskselector add a idler and remove in _move_scroller with checking
> wd->idler
> But in elm_diskselector_item_selected_set, it's not use wd->idler.
> So idler is called infinite.
>
> It also registered in ticket ( http://trac.enlightenment.org/e/ticket/854 )
>
> Thank you

On Wed, Sep 7, 2011 at 7:00 PM, Hyoyoung Chang <hyoyoung.chang@samsung.com> wrote:
> I omitted about credit.
> With cnook, I can easily find this bug.
> Thanks to cnook

git-svn-id: svn+ssh://svn.enlightenment.org/var/svn/e/trunk/elementary@63269 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

diff --git a/src/lib/elm_diskselector.c b/src/lib/elm_diskselector.c
index e467aeb..66625f6 100644 (file)
--- a/src/lib/elm_diskselector.c
+++ b/src/lib/elm_diskselector.c
@@ -1181,7 +1181,7 @@ elm_diskselector_item_selected_set(Elm_Diskselector_Item *it, Eina_Bool selected
      }
 
    if (!wd->idler)
-     ecore_idler_add(_move_scroller, it->base.widget);
+     wd->idler = ecore_idler_add(_move_scroller, it->base.widget);
 }
 
 EAPI Eina_Bool