Don't return http proxy for server usages
authorShane Kearns <ext-shane.2.kearns@nokia.com>
Tue, 8 May 2012 17:09:02 +0000 (18:09 +0100)
committerQt by Nokia <qt-info@nokia.com>
Thu, 10 May 2012 23:42:02 +0000 (01:42 +0200)
Http proxy cannot support server sockets or udp sockets, so don't
offer it as the system proxy (in the generic environment variables
implementation)

Change-Id: I234ab1024952b2630e668ddc35c665efade8e2b9
Reviewed-by: Adrien Bustany <adrien@bustany.org>
Reviewed-by: Martin Petersson <Martin.Petersson@nokia.com>
src/network/kernel/qnetworkproxy_generic.cpp

index 61aedbe..bb3ae47 100644 (file)
@@ -119,7 +119,9 @@ QList<QNetworkProxy> QNetworkProxyFactory::systemProxyForQuery(const QNetworkPro
                     url.port() ? url.port() : 1080, url.userName(), url.password());
             proxy.setCapabilities(QNetworkProxy::HostNameLookupCapability);
             proxyList << proxy;
-        } else if (url.scheme() == QLatin1String("http") || url.scheme().isEmpty()) {
+        } else if ((url.scheme() == QLatin1String("http") || url.scheme().isEmpty())
+                  && query.queryType() != QNetworkProxyQuery::UdpSocket
+                  && query.queryType() != QNetworkProxyQuery::TcpServer) {
             QNetworkProxy proxy(QNetworkProxy::HttpProxy, url.host(),
                     url.port() ? url.port() : 8080, url.userName(), url.password());
             proxyList << proxy;