pinctrl: single: Fix error return code in pcs_parse_bits_in_pinctrl_entry()
authorZhen Lei <thunder.leizhen@huawei.com>
Thu, 22 Jul 2021 03:39:29 +0000 (11:39 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 18 Sep 2021 11:40:14 +0000 (13:40 +0200)
[ Upstream commit d789a490d32fdf0465275e3607f8a3bc87d3f3ba ]

Fix to return -ENOTSUPP instead of 0 when PCS_HAS_PINCONF is true, which
is the same as that returned in pcs_parse_pinconf().

Fixes: 4e7e8017a80e ("pinctrl: pinctrl-single: enhance to configure multiple pins of different modules")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Link: https://lore.kernel.org/r/20210722033930.4034-2-thunder.leizhen@huawei.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pinctrl/pinctrl-single.c

index 12cc4eb..17aa0d5 100644 (file)
@@ -1222,6 +1222,7 @@ static int pcs_parse_bits_in_pinctrl_entry(struct pcs_device *pcs,
 
        if (PCS_HAS_PINCONF) {
                dev_err(pcs->dev, "pinconf not supported\n");
+               res = -ENOTSUPP;
                goto free_pingroups;
        }