net/sonic: Remove redundant netif_start_queue() call
authorFinn Thain <fthain@telegraphics.com.au>
Sat, 15 Feb 2020 21:03:32 +0000 (08:03 +1100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 17 Feb 2020 03:48:22 +0000 (19:48 -0800)
The transmit queue must be running already otherwise sonic_send_packet()
would not have been called. If the queue was stopped by the interrupt
handler, the interrupt handler will restart it again.

Tested-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/natsemi/sonic.c

index 9ecdd67e1410af3e4182b011c040fd502363368f..1d6de6706875e39e82103299dcdcd0f548840436 100644 (file)
@@ -327,7 +327,7 @@ static int sonic_send_packet(struct sk_buff *skb, struct net_device *dev)
                netif_dbg(lp, tx_queued, dev, "%s: stopping queue\n", __func__);
                netif_stop_queue(dev);
                /* after this packet, wait for ISR to free up some TDAs */
-       } else netif_start_queue(dev);
+       }
 
        netif_dbg(lp, tx_queued, dev, "%s: issuing Tx command\n", __func__);