docs/random/ds/0.9-suggested-changes: Add a note to change handoff use in fakesrc...

Original commit message from CVS:
* docs/random/ds/0.9-suggested-changes:
Add a note to change handoff use in fakesrc to be usable in
a more generic way (fakesrc should be renamed to appsrc or so).
* gst/elements/gstfakesrc.c: (gst_fakesrc_class_init):
Change signal type to scope, so we can fill the buffer in the
handoff handler (that's the whole use of this signal...).

diff --git a/ChangeLog b/ChangeLog
index 77bbd46..dc34e53 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,14 @@
 2004-04-01  Ronald Bultje  <rbultje@ronald.bitfreak.net>
 
+       * docs/random/ds/0.9-suggested-changes:
+         Add a note to change handoff use in fakesrc to be usable in
+         a more generic way (fakesrc should be renamed to appsrc or so).
+       * gst/elements/gstfakesrc.c: (gst_fakesrc_class_init):
+         Change signal type to scope, so we can fill the buffer in the
+         handoff handler (that's the whole use of this signal...).
+
+2004-04-01  Ronald Bultje  <rbultje@ronald.bitfreak.net>
+
        * docs/pwg/other-ntoone.xml:
          Document muxers and n-to-1 elements.
 

diff --git a/docs/random/ds/0.9-suggested-changes b/docs/random/ds/0.9-suggested-changes
index 4b085bb..4d0ce82 100644 (file)
--- a/docs/random/ds/0.9-suggested-changes
+++ b/docs/random/ds/0.9-suggested-changes
@@ -40,6 +40,9 @@ API:
  - deprecate gst_buffer_merge() and replace with a function that takes
    ownership of the buffers.  (bug #136408)
 
+ - fakesrc handoff should be changed to return a GstData * or carry a
+    GstData **, wo the user can provide own buffers and events.
+
 caps:
 
   (Company:)

diff --git a/gst/elements/gstfakesrc.c b/gst/elements/gstfakesrc.c
index 1901d21..c9a44f7 100644 (file)
--- a/gst/elements/gstfakesrc.c
+++ b/gst/elements/gstfakesrc.c
@@ -260,7 +260,7 @@ gst_fakesrc_class_init (GstFakeSrcClass * klass)
       g_signal_new ("handoff", G_TYPE_FROM_CLASS (klass), G_SIGNAL_RUN_LAST,
       G_STRUCT_OFFSET (GstFakeSrcClass, handoff), NULL, NULL,
       gst_marshal_VOID__POINTER_OBJECT, G_TYPE_NONE, 2,
-      GST_TYPE_BUFFER, GST_TYPE_PAD);
+      GST_TYPE_BUFFER | G_SIGNAL_TYPE_STATIC_SCOPE, GST_TYPE_PAD);
 
   gobject_class->set_property = GST_DEBUG_FUNCPTR (gst_fakesrc_set_property);
   gobject_class->get_property = GST_DEBUG_FUNCPTR (gst_fakesrc_get_property);

diff --git a/plugins/elements/gstfakesrc.c b/plugins/elements/gstfakesrc.c
index 1901d21..c9a44f7 100644 (file)
--- a/plugins/elements/gstfakesrc.c
+++ b/plugins/elements/gstfakesrc.c
@@ -260,7 +260,7 @@ gst_fakesrc_class_init (GstFakeSrcClass * klass)
       g_signal_new ("handoff", G_TYPE_FROM_CLASS (klass), G_SIGNAL_RUN_LAST,
       G_STRUCT_OFFSET (GstFakeSrcClass, handoff), NULL, NULL,
       gst_marshal_VOID__POINTER_OBJECT, G_TYPE_NONE, 2,
-      GST_TYPE_BUFFER, GST_TYPE_PAD);
+      GST_TYPE_BUFFER | G_SIGNAL_TYPE_STATIC_SCOPE, GST_TYPE_PAD);
 
   gobject_class->set_property = GST_DEBUG_FUNCPTR (gst_fakesrc_set_property);
   gobject_class->get_property = GST_DEBUG_FUNCPTR (gst_fakesrc_get_property);