gst/base/gstbasesrc.c: Don't unref the caps we passed to gst_caps_make_writable(...

Original commit message from CVS:
* gst/base/gstbasesrc.c: (gst_base_src_default_negotiate):
Don't unref the caps we passed to gst_caps_make_writable() after
passing them. gst_caps_make_writable() will do that for us.

diff --git a/ChangeLog b/ChangeLog
index c09cc204140780e766c6094a22b7554909ef64b1..eff957acf3c2d3d2ca3a6f12bb882f923fa30354 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2005-07-16  Tim-Philipp Müller  <tim at centricular dot net>
+
+       * gst/base/gstbasesrc.c: (gst_base_src_default_negotiate):
+         Don't unref the caps we passed to gst_caps_make_writable() after
+         passing them. gst_caps_make_writable() will do that for us.
+
 2005-07-15  Andy Wingo  <wingo@pobox.com>
 
        * gst/gstcaps.h (gst_caps_is_simple): Removed deprecated macro

diff --git a/gst/base/gstbasesrc.c b/gst/base/gstbasesrc.c
index 179410925ec070eacf91ccf4ee50b745bee1177c..88720a0a5ee1b43bd6cf3e97181443c2f6e00697 100644 (file)
--- a/gst/base/gstbasesrc.c
+++ b/gst/base/gstbasesrc.c
@@ -785,11 +785,7 @@ gst_base_src_default_negotiate (GstBaseSrc * basesrc)
     caps = thiscaps;
   }
   if (caps) {
-    GstCaps *normalized;
-
-    normalized = gst_caps_make_writable (caps);
-    gst_caps_unref (caps);
-    caps = normalized;
+    caps = gst_caps_make_writable (caps);
     gst_caps_truncate (caps);
 
     gst_pad_fixate_caps (GST_BASE_SRC_PAD (basesrc), caps);

diff --git a/libs/gst/base/gstbasesrc.c b/libs/gst/base/gstbasesrc.c
index 179410925ec070eacf91ccf4ee50b745bee1177c..88720a0a5ee1b43bd6cf3e97181443c2f6e00697 100644 (file)
--- a/libs/gst/base/gstbasesrc.c
+++ b/libs/gst/base/gstbasesrc.c
@@ -785,11 +785,7 @@ gst_base_src_default_negotiate (GstBaseSrc * basesrc)
     caps = thiscaps;
   }
   if (caps) {
-    GstCaps *normalized;
-
-    normalized = gst_caps_make_writable (caps);
-    gst_caps_unref (caps);
-    caps = normalized;
+    caps = gst_caps_make_writable (caps);
     gst_caps_truncate (caps);
 
     gst_pad_fixate_caps (GST_BASE_SRC_PAD (basesrc), caps);