mei: Remove some dead code
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Fri, 12 Nov 2021 10:06:33 +0000 (11:06 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 3 Dec 2021 13:26:33 +0000 (14:26 +0100)
'generated' is known to be true here, so "true || whatever" will still be
true.

So, remove some dead code.

Acked-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/3f904c291f3eed06223dd8d494028e0d49df6f10.1636711522.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/mei/hw-txe.c

index a4e854b..00652c1 100644 (file)
@@ -994,11 +994,7 @@ static bool mei_txe_check_and_ack_intrs(struct mei_device *dev, bool do_ack)
                hhisr &= ~IPC_HHIER_SEC;
        }
 
-       generated = generated ||
-               (hisr & HISR_INT_STS_MSK) ||
-               (ipc_isr & SEC_IPC_HOST_INT_STATUS_PENDING);
-
-       if (generated && do_ack) {
+       if (do_ack) {
                /* Save the interrupt causes */
                hw->intr_cause |= hisr & HISR_INT_STS_MSK;
                if (ipc_isr & SEC_IPC_HOST_INT_STATUS_IN_RDY)