libs/gst/base/gstcollectpads.c: fix changelog entry about last collectpads change...

Original commit message from CVS:
* libs/gst/base/gstcollectpads.c: (gst_collect_pads_event):
fix changelog entry about last collectpads change,
add notes about proper fix

diff --git a/ChangeLog b/ChangeLog
index 1bd46da..8e6f2de 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,11 @@
 2006-04-28  Stefan Kost  <ensonic@users.sf.net>
 
+       * libs/gst/base/gstcollectpads.c: (gst_collect_pads_event):
+        fix changelog entry about last collectpads change,
+        add notes about proper fix
+
+2006-04-28  Stefan Kost  <ensonic@users.sf.net>
+
        * gst/gst.c:
        * gst/gstregistry.c: (gst_registry_scan_path_level),
        (gst_registry_scan_path):

diff --git a/libs/gst/base/gstcollectpads.c b/libs/gst/base/gstcollectpads.c
index 3fe515c..ff40dbb 100644 (file)
--- a/libs/gst/base/gstcollectpads.c
+++ b/libs/gst/base/gstcollectpads.c
@@ -743,6 +743,15 @@ gst_collect_pads_event (GstPad * pad, GstEvent * event)
 
       /* forward to src-pad, sink-elements like to get the event */
       gst_pad_event_default (pad, event);
+      /* FIXME: collect-pads based elements need to create their own newsegment
+         event (and only one really)
+         (a) make the segment part of the GstCollectData structure of each pad,
+         so you can just check that once you have a buffer queued on that pad,
+         (b) you can override a pad's event function with your own,
+         catch the newsegment event and then pass it on to the original
+         gstcollectpads event function
+         (that's what avimux does for something IIRC)
+       */
       return TRUE;
     }
     default: