tpm: cleanup tpm_tis_remove()
authorJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Thu, 31 Mar 2016 10:05:36 +0000 (13:05 +0300)
committerJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Sat, 25 Jun 2016 14:26:35 +0000 (17:26 +0300)
Created a local variable pointing to the INT_ENABLE_x register. The
expression clearing INT_ENABLE_x.globalIntEnable is unreadable and
hard to modify without surpassing the 80 char boundary.

Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Tested-by: Christophe Ricard <christophe-h.ricard@st.com>
drivers/char/tpm/tpm_tis.c

index eed3bf5..18236f6 100644 (file)
@@ -650,15 +650,13 @@ MODULE_PARM_DESC(interrupts, "Enable interrupts");
 
 static void tpm_tis_remove(struct tpm_chip *chip)
 {
+       void __iomem *reg = chip->vendor.iobase +
+               TPM_INT_ENABLE(chip->vendor.locality);
+
        if (chip->flags & TPM_CHIP_FLAG_TPM2)
                tpm2_shutdown(chip, TPM2_SU_CLEAR);
 
-       iowrite32(~TPM_GLOBAL_INT_ENABLE &
-                 ioread32(chip->vendor.iobase +
-                          TPM_INT_ENABLE(chip->vendor.
-                                         locality)),
-                 chip->vendor.iobase +
-                 TPM_INT_ENABLE(chip->vendor.locality));
+       iowrite32(~TPM_GLOBAL_INT_ENABLE & ioread32(reg), reg);
        release_locality(chip, chip->vendor.locality, 1);
 }