target-i386: Fix CC_OP_CLR vs PF
authorRichard Henderson <rth@twiddle.net>
Fri, 10 Jan 2014 20:38:40 +0000 (12:38 -0800)
committerRichard Henderson <rth@twiddle.net>
Fri, 28 Feb 2014 16:43:15 +0000 (08:43 -0800)
Parity should be set for a zero result.

Cc: qemu-stable@nongnu.org
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Signed-off-by: Richard Henderson <rth@twiddle.net>
target-i386/cc_helper.c
target-i386/translate.c

index ee04092..05dd12b 100644 (file)
@@ -103,7 +103,7 @@ target_ulong helper_cc_compute_all(target_ulong dst, target_ulong src1,
     case CC_OP_EFLAGS:
         return src1;
     case CC_OP_CLR:
-        return CC_Z;
+        return CC_Z | CC_P;
 
     case CC_OP_MULB:
         return compute_all_mulb(dst, src1);
index 5dd2450..aa985fa 100644 (file)
@@ -748,7 +748,7 @@ static void gen_compute_eflags(DisasContext *s)
         return;
     }
     if (s->cc_op == CC_OP_CLR) {
-        tcg_gen_movi_tl(cpu_cc_src, CC_Z);
+        tcg_gen_movi_tl(cpu_cc_src, CC_Z | CC_P);
         set_cc_op(s, CC_OP_EFLAGS);
         return;
     }