pinctrl: madera: Return ENOTSUPP for unsupported pin attributes
authorRichard Fitzgerald <rf@opensource.cirrus.com>
Tue, 7 Aug 2018 09:32:25 +0000 (10:32 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 29 Aug 2018 08:42:02 +0000 (10:42 +0200)
The pin_config_[get|set] functions should return ENOTSUPP if
the requested attribute isn't supported.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/cirrus/pinctrl-madera-core.c

index 4f9b7e3..4ba56ca 100644 (file)
@@ -801,7 +801,7 @@ static int madera_pin_conf_get(struct pinctrl_dev *pctldev, unsigned int pin,
                        result = 1;
                break;
        default:
-               break;
+               return -ENOTSUPP;
        }
 
        *config = pinconf_to_config_packed(param, result);
@@ -905,7 +905,7 @@ static int madera_pin_conf_set(struct pinctrl_dev *pctldev, unsigned int pin,
                        conf[1] &= ~MADERA_GP1_DIR;
                        break;
                default:
-                       break;
+                       return -ENOTSUPP;
                }
 
                ++configs;