flacdec: fix theoretical integer overflow
authorVincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Fri, 2 May 2014 12:59:07 +0000 (13:59 +0100)
committerVincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Fri, 2 May 2014 12:59:07 +0000 (13:59 +0100)
This code isn't actually used at the moment, unsure if I should
just remove it or not...

Coverity 1139811

ext/flac/gstflacdec.c

index 08a93bd..3537fc2 100644 (file)
@@ -421,7 +421,7 @@ gst_flac_dec_scan_got_frame (GstFlacDec * flacdec, guint8 * data, guint size,
   }
 
   if (flacdec->min_blocksize == flacdec->max_blocksize) {
-    *last_sample_num = (val + 1) * flacdec->min_blocksize;
+    *last_sample_num = ((guint64) val + 1) * flacdec->min_blocksize;
   } else {
     *last_sample_num = 0;       /* FIXME: + length of last block in samples */
   }