Revert "e_input: fixed leak regarding ecore_device removal" 17/266517/1 accepted/tizen/6.5/unified/20211116.032717 submit/tizen_6.5/20211115.020239
authorDoyoun Kang <doyoun.kang@samsung.com>
Fri, 12 Nov 2021 07:29:59 +0000 (16:29 +0900)
committerDoyoun Kang <doyoun.kang@samsung.com>
Sat, 13 Nov 2021 04:21:22 +0000 (13:21 +0900)
This reverts commit df2baaee8044d11534192c57bb3aa058d5863b5b.

Change-Id: Ibb59da3e1f213e6d4875ba11eaffc0aaba893aa8

src/bin/e_input_inputs.c

index 284c9ea473deb5feef4179af264bad8e02d87bc9..c33a8c3d3e8c244d9078eb81c1c49f42d3ea2c7e 100644 (file)
@@ -224,18 +224,13 @@ _e_input_remove_ecore_device(E_Input_Evdev *edev, Ecore_Device_Class clas)
          if (!identifier) continue;
          if ((ecore_device_class_get(dev) == clas) && (!strcmp(identifier, edev->path)))
            {
-              if (edev->ecore_dev)
-                {
-                   ecore_device_unref(dev);
-                   edev->ecore_dev = NULL;
-                }
+              if (edev->ecore_dev) edev->ecore_dev = NULL;
               else if (edev->ecore_dev_list)
                 {
                    EINA_LIST_FOREACH_SAFE(edev->ecore_dev_list, ll, ll_next, data)
                      {
                         if (data == dev)
                           {
-                             ecore_device_unref(dev);
                              edev->ecore_dev_list = eina_list_remove_list(edev->ecore_dev_list, ll);
                           }
                      }
@@ -306,7 +301,6 @@ _e_input_device_remove(E_Input_Evdev *edev)
                   WRN("Invalid device is left. name: %s, identifier: %s, clas: %s\n",
                       ecore_device_name_get(data), ecore_device_description_get(data),
                       _e_input_ecore_device_class_to_string(ecore_device_class_get(data)));
-                  ecore_device_unref(data);
                   ecore_device_del(data);
                }
           }