Replace a call to a missing method with a warning

system-popup doesn't actually expose the MalfunctionNotifierLaunch method,
at least the upstream version. The function was only disabled instead of
completely removed to give any potential legacy systems or forks time to
adapt.

Change-Id: I45884184b4b7734bbe9b1c24692e7fd62d4df258
Signed-off-by: Michal Bloch <m.bloch@samsung.com>

diff --git a/src/heart/heart-abnormal.c b/src/heart/heart-abnormal.c
index 1ef466d..a12f3bf 100644 (file)
--- a/src/heart/heart-abnormal.c
+++ b/src/heart/heart-abnormal.c
@@ -114,6 +114,19 @@ unlock_exit:
 
 static void heart_abnormal_launch_popup(char *appid, int count)
 {
+       _W("A malfunction popup is supposed to be created here, but system-popup "
+          "doesn't actually expose a MalfunctionNotifierLaunch DBus method and "
+          "this legacy functionality is deprecated.");
+
+#if 0
+       /* Dead code (see above); it has been disabled instead of outright removed
+        * because I've seen too many braindead repository copy-pastes annihilating
+        * git history to trust people to be able to find this code in case their
+        * legacy system suddenly stops working and I don't want to deal with the
+        * flak I could be getting for it. In a year or two (unless somebody patches
+        * system-popup to add MalfurionNotifierLaunch or some other good reason
+        * appears) it would be good to get rid of this code though. */
+
        int ret;
        char num[10];
        char _appid[MAX_APPID_LENGTH];
@@ -138,6 +151,7 @@ static void heart_abnormal_launch_popup(char *appid, int count)
                _E("Failed to launch MalfunctionNotifier");
        else
                _I("MalfunctionNotifierLaunch Success");
+#endif
 }
 
 static void heart_abnormal_process_crashed(GVariant *params)