OMAPDSS: apply affects only one overlay manager
authorTomi Valkeinen <tomi.valkeinen@ti.com>
Fri, 4 Nov 2011 07:23:10 +0000 (09:23 +0200)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Fri, 2 Dec 2011 06:54:30 +0000 (08:54 +0200)
omap_dss_mgr_apply currently applies settings to all overlays and
overlay managers. The reason for this was to support cases where
configuration changes affecting multiple managers are made. However, the
current code doesn't support changing such configurations, so the
functionality is not needed.

Change the apply to affect only the manager given as an argument, and
the overlays attached to that manager.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/video/omap2/dss/manager.c

index d0d2315..d2bdd65 100644 (file)
@@ -1114,23 +1114,28 @@ static int omap_dss_mgr_apply(struct omap_overlay_manager *mgr)
        spin_lock_irqsave(&dss_cache.lock, flags);
 
        /* Configure overlays */
-       for (i = 0; i < omap_dss_get_num_overlays(); ++i) {
+       for (i = 0; i < mgr->num_overlays; ++i) {
                struct omap_overlay *ovl;
 
-               ovl = omap_dss_get_overlay(i);
+               ovl = mgr->overlays[i];
+
+               if (ovl->manager != mgr)
+                       continue;
 
                omap_dss_mgr_apply_ovl(ovl);
        }
 
-       /* Configure managers */
-       list_for_each_entry(mgr, &manager_list, list)
-               omap_dss_mgr_apply_mgr(mgr);
+       /* Configure manager */
+       omap_dss_mgr_apply_mgr(mgr);
 
        /* Configure overlay fifos */
-       for (i = 0; i < omap_dss_get_num_overlays(); ++i) {
+       for (i = 0; i < mgr->num_overlays; ++i) {
                struct omap_overlay *ovl;
 
-               ovl = omap_dss_get_overlay(i);
+               ovl = mgr->overlays[i];
+
+               if (ovl->manager != mgr)
+                       continue;
 
                omap_dss_mgr_apply_ovl_fifos(ovl);
        }