rpmsg: qcom_smd: Fix returning 0 if irq_of_parse_and_map() fails
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Sat, 23 Apr 2022 09:39:32 +0000 (11:39 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Jun 2022 16:36:05 +0000 (18:36 +0200)
[ Upstream commit 59d6f72f6f9c92fec8757d9e29527da828e9281f ]

irq_of_parse_and_map() returns 0 on failure, so this should not be
passed further as error return code.

Fixes: 1a358d350664 ("rpmsg: qcom_smd: Fix irq_of_parse_and_map() return value")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20220423093932.32136-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/rpmsg/qcom_smd.c

index 775a7e4..370688e 100644 (file)
@@ -1406,7 +1406,7 @@ static int qcom_smd_parse_edge(struct device *dev,
        irq = irq_of_parse_and_map(node, 0);
        if (!irq) {
                dev_err(dev, "required smd interrupt missing\n");
-               ret = irq;
+               ret = -EINVAL;
                goto put_node;
        }