projects
/
platform
/
upstream
/
weston.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
e5e8188
)
ivi-shell: fix init error path
author
Pekka Paalanen
<pekka.paalanen@collabora.com>
Wed, 6 Nov 2019 10:07:23 +0000
(12:07 +0200)
committer
Daniel Stone
<daniel@fooishbar.org>
Thu, 21 Nov 2019 16:32:55 +0000
(16:32 +0000)
This was forgetting to remove the compositor destroy listener if init failed,
which would lead to use-after-free on compositor tear-down. Found by
inspection.
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
ivi-shell/ivi-shell.c
patch
|
blob
|
history
diff --git
a/ivi-shell/ivi-shell.c
b/ivi-shell/ivi-shell.c
index 244290b871fc4163a4a7ae0f4e370e0515791c27..99431d0bde0fcf4c564bf4c197bd5088a0641c51 100644
(file)
--- a/
ivi-shell/ivi-shell.c
+++ b/
ivi-shell/ivi-shell.c
@@
-649,6
+649,7
@@
err_desktop:
weston_desktop_destroy(shell->desktop);
err_shell:
+ wl_list_remove(&shell->destroy_listener.link);
free(shell);
return IVI_FAILED;