wifi: mt76: mt7915: do not check state before configuring implicit beamform
authorHoward Hsu <howard-yh.hsu@mediatek.com>
Thu, 18 Aug 2022 02:44:07 +0000 (10:44 +0800)
committerFelix Fietkau <nbd@nbd.name>
Thu, 15 Sep 2022 11:21:39 +0000 (13:21 +0200)
Do not need to check running state before configuring implicit Tx
beamform. It is okay to configure implicit Tx beamform in run time.
Noted that the existing connected stations will be applied for new
configuration only if they reconnected to the interface.

Fixes: 6d6dc980e07d ("mt76: mt7915: add implicit Tx beamforming support")
Signed-off-by: Howard Hsu <howard-yh.hsu@mediatek.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c

index fd76db8f5269c401a222c08700aab4ed60d63742..6ef3431cad6483332f2b463f70198d92f5d3db90 100644 (file)
@@ -23,9 +23,9 @@ mt7915_implicit_txbf_set(void *data, u64 val)
 {
        struct mt7915_dev *dev = data;
 
-       if (test_bit(MT76_STATE_RUNNING, &dev->mphy.state))
-               return -EBUSY;
-
+       /* The existing connected stations shall reconnect to apply
+        * new implicit txbf configuration.
+        */
        dev->ibf = !!val;
 
        return mt7915_mcu_set_txbf(dev, MT_BF_TYPE_UPDATE);