Nullify 'new' after dropping its reference, so that we return NULL.

2007-05-07  Matthew Barnes  <mbarnes@redhat.com>

	* libedataserver/e-source-group.c (e_source_group_new_from_xmldoc):
	Nullify 'new' after dropping its reference, so that we return NULL.

svn path=/trunk/; revision=7730

diff --git a/ChangeLog b/ChangeLog
index 290d210..ddc4db6 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
 2007-05-07  Matthew Barnes  <mbarnes@redhat.com>
 
+       * libedataserver/e-source-group.c (e_source_group_new_from_xmldoc):
+       Nullify 'new' after dropping its reference, so that we return NULL.
+
+2007-05-07  Matthew Barnes  <mbarnes@redhat.com>
+
        * docs/reference/camel/Makefile.am:
        Remove reference to nonexistent libutil.la.
 

diff --git a/libedataserver/e-source-group.c b/libedataserver/e-source-group.c
index b14053f..dd97710 100644 (file)
--- a/libedataserver/e-source-group.c
+++ b/libedataserver/e-source-group.c
@@ -229,6 +229,7 @@ e_source_group_new_from_xmldoc (xmlDocPtr doc)
 
                if (new_source == NULL) {
                        g_object_unref (new);
+                       new = NULL;
                        goto done;
                }
                e_source_group_add_source (new, new_source, -1);