ALSA: ac97: set variables dev_attr_vendor_id to static
authorYu Liao <liaoyu15@huawei.com>
Wed, 2 Aug 2023 02:26:49 +0000 (10:26 +0800)
committerTakashi Iwai <tiwai@suse.de>
Wed, 2 Aug 2023 07:27:39 +0000 (09:27 +0200)
sparse reports
sound/ac97/bus.c:465:1: sparse: sparse: symbol 'dev_attr_vendor_id' was not declared. Should it be static?

This variable is only used in its defining file, so it should be static.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202307242300.Oy0Dp2QI-lkp@intel.com/
Signed-off-by: Yu Liao <liaoyu15@huawei.com>
Link: https://lore.kernel.org/r/20230802022649.2514787-1-liaoyu15@huawei.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/ac97/bus.c

index 6067c04..3173e9d 100644 (file)
@@ -462,7 +462,7 @@ static ssize_t vendor_id_show(struct device *dev,
 
        return sysfs_emit(buf, "%08x", codec->vendor_id);
 }
-DEVICE_ATTR_RO(vendor_id);
+static DEVICE_ATTR_RO(vendor_id);
 
 static struct attribute *ac97_dev_attrs[] = {
        &dev_attr_vendor_id.attr,