firmware: arm_scmi: remove redundant null check on array
authorColin Ian King <colin.king@canonical.com>
Wed, 21 Mar 2018 18:01:58 +0000 (18:01 +0000)
committerSudeep Holla <sudeep.holla@arm.com>
Mon, 16 Apr 2018 09:15:58 +0000 (10:15 +0100)
The null check on clk->name is redundant since name is a char array
and can never be null, so the check is always true.  Remove it.

Detected by CoverityScan, CID#1466117 ("Array compared against 0")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
drivers/firmware/arm_scmi/clock.c

index e6f1782..2b90606 100644 (file)
@@ -284,7 +284,7 @@ scmi_clock_info_get(const struct scmi_handle *handle, u32 clk_id)
        struct clock_info *ci = handle->clk_priv;
        struct scmi_clock_info *clk = ci->clk + clk_id;
 
-       if (!clk->name || !clk->name[0])
+       if (!clk->name[0])
                return NULL;
 
        return clk;