media: dvb-usb: make dvb_usb_device_properties const
authorSean Young <sean@mess.org>
Tue, 14 Apr 2020 10:10:43 +0000 (12:10 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 21 Apr 2020 10:56:10 +0000 (12:56 +0200)
This makes it possible to declare dvb_usb_device_properties const.

Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
15 files changed:
drivers/media/usb/dvb-usb/a800.c
drivers/media/usb/dvb-usb/af9005.c
drivers/media/usb/dvb-usb/az6027.c
drivers/media/usb/dvb-usb/cxusb.c
drivers/media/usb/dvb-usb/dib0700.h
drivers/media/usb/dvb-usb/dib0700_core.c
drivers/media/usb/dvb-usb/digitv.c
drivers/media/usb/dvb-usb/dvb-usb-common.h
drivers/media/usb/dvb-usb/dvb-usb-firmware.c
drivers/media/usb/dvb-usb/dvb-usb-init.c
drivers/media/usb/dvb-usb/dvb-usb.h
drivers/media/usb/dvb-usb/dw2102.c
drivers/media/usb/dvb-usb/m920x.c
drivers/media/usb/dvb-usb/technisat-usb2.c
drivers/media/usb/dvb-usb/ttusb2.c

index 15bbefe..36b5b62 100644 (file)
@@ -27,8 +27,10 @@ static int a800_power_ctrl(struct dvb_usb_device *d, int onoff)
 }
 
 /* assure to put cold to 0 for iManufacturer == 1 */
-static int a800_identify_state(struct usb_device *udev, struct dvb_usb_device_properties *props,
-       struct dvb_usb_device_description **desc, int *cold)
+static int a800_identify_state(struct usb_device *udev,
+                              const struct dvb_usb_device_properties *props,
+                              const struct dvb_usb_device_description **desc,
+                              int *cold)
 {
        *cold = udev->descriptor.iManufacturer != 1;
        return 0;
index 3446bca..b6a2436 100644 (file)
@@ -955,8 +955,8 @@ static int af9005_pid_filter(struct dvb_usb_adapter *adap, int index,
 }
 
 static int af9005_identify_state(struct usb_device *udev,
-                                struct dvb_usb_device_properties *props,
-                                struct dvb_usb_device_description **desc,
+                                const struct dvb_usb_device_properties *props,
+                                const struct dvb_usb_device_description **desc,
                                 int *cold)
 {
        int ret;
index d5be540..1c39b61 100644 (file)
@@ -1051,8 +1051,8 @@ static struct i2c_algorithm az6027_i2c_algo = {
 };
 
 static int az6027_identify_state(struct usb_device *udev,
-                                struct dvb_usb_device_properties *props,
-                                struct dvb_usb_device_description **desc,
+                                const struct dvb_usb_device_properties *props,
+                                const struct dvb_usb_device_description **desc,
                                 int *cold)
 {
        u8 *b;
index fd058f7..761992a 100644 (file)
@@ -1358,8 +1358,8 @@ static int cxusb_mygica_d689_frontend_attach(struct dvb_usb_adapter *adap)
  * not, and forget a match if it turns out we selected the wrong device.
  */
 static int bluebird_fx2_identify_state(struct usb_device *udev,
-                                      struct dvb_usb_device_properties *props,
-                                      struct dvb_usb_device_description **desc,
+                                      const struct dvb_usb_device_properties *props,
+                                      const struct dvb_usb_device_description **desc,
                                       int *cold)
 {
        int wascold = *cold;
index ca4d3d2..2defbd8 100644 (file)
@@ -52,20 +52,25 @@ struct dib0700_state {
        struct i2c_client *i2c_client_tuner;
 };
 
-extern int dib0700_get_version(struct dvb_usb_device *d, u32 *hwversion,
-                              u32 *romversion, u32 *ramversion, u32 *fwtype);
-extern int dib0700_set_gpio(struct dvb_usb_device *, enum dib07x0_gpios gpio, u8 gpio_dir, u8 gpio_val);
-extern int dib0700_ctrl_clock(struct dvb_usb_device *d, u32 clk_MHz, u8 clock_out_gp3);
-extern int dib0700_ctrl_rd(struct dvb_usb_device *d, u8 *tx, u8 txlen, u8 *rx, u8 rxlen);
-extern int dib0700_download_firmware(struct usb_device *udev, const struct firmware *fw);
-extern int dib0700_rc_setup(struct dvb_usb_device *d, struct usb_interface *intf);
-extern int dib0700_streaming_ctrl(struct dvb_usb_adapter *adap, int onoff);
-extern struct i2c_algorithm dib0700_i2c_algo;
-extern int dib0700_identify_state(struct usb_device *udev, struct dvb_usb_device_properties *props,
-                       struct dvb_usb_device_description **desc, int *cold);
-extern int dib0700_change_protocol(struct rc_dev *dev, u64 *rc_proto);
-extern int dib0700_set_i2c_speed(struct dvb_usb_device *d, u16 scl_kHz);
+int dib0700_get_version(struct dvb_usb_device *d, u32 *hwversion,
+                       u32 *romversion, u32 *ramversion, u32 *fwtype);
+int dib0700_set_gpio(struct dvb_usb_device *d, enum dib07x0_gpios gpio,
+                    u8 gpio_dir, u8 gpio_val);
+int dib0700_ctrl_clock(struct dvb_usb_device *d, u32 clk_MHz, u8 clock_out_gp3);
+int dib0700_ctrl_rd(struct dvb_usb_device *d, u8 *tx, u8 txlen, u8 *rx,
+                   u8 rxlen);
+int dib0700_download_firmware(struct usb_device *d,
+                             const struct firmware *fw);
+int dib0700_rc_setup(struct dvb_usb_device *d, struct usb_interface *intf);
+int dib0700_streaming_ctrl(struct dvb_usb_adapter *adap, int onoff);
+int dib0700_identify_state(struct usb_device *d,
+                          const struct dvb_usb_device_properties *props,
+                          const struct dvb_usb_device_description **desc,
+                          int *cold);
+int dib0700_change_protocol(struct rc_dev *dev, u64 *rc_proto);
+int dib0700_set_i2c_speed(struct dvb_usb_device *d, u16 scl_kHz);
 
+extern struct i2c_algorithm dib0700_i2c_algo;
 extern int dib0700_device_count;
 extern int dvb_usb_dib0700_ir_proto;
 extern struct dvb_usb_device_properties dib0700_devices[];
index ef62dd6..70219b3 100644 (file)
@@ -372,8 +372,10 @@ struct i2c_algorithm dib0700_i2c_algo = {
        .functionality = dib0700_i2c_func,
 };
 
-int dib0700_identify_state(struct usb_device *udev, struct dvb_usb_device_properties *props,
-                       struct dvb_usb_device_description **desc, int *cold)
+int dib0700_identify_state(struct usb_device *udev,
+                          const struct dvb_usb_device_properties *props,
+                          const struct dvb_usb_device_description **desc,
+                          int *cold)
 {
        s16 ret;
        u8 *b;
index 2a4b7cc..4e3b3c0 100644 (file)
@@ -90,9 +90,10 @@ static struct i2c_algorithm digitv_i2c_algo = {
 };
 
 /* Callbacks for DVB USB */
-static int digitv_identify_state (struct usb_device *udev, struct
-               dvb_usb_device_properties *props, struct dvb_usb_device_description **desc,
-               int *cold)
+static int digitv_identify_state(struct usb_device *udev,
+                                const struct dvb_usb_device_properties *props,
+                                const struct dvb_usb_device_description **desc,
+                                int *cold)
 {
        *cold = udev->descriptor.iManufacturer == 0 && udev->descriptor.iProduct == 0;
        return 0;
index 8c51ac4..70f4eed 100644 (file)
@@ -26,7 +26,8 @@ extern int dvb_usb_disable_rc_polling;
 #define deb_uxfer(args...) dprintk(dvb_usb_debug,0x100,args)
 
 /* commonly used  methods */
-extern int dvb_usb_download_firmware(struct usb_device *, struct dvb_usb_device_properties *);
+int dvb_usb_download_firmware(struct usb_device *udev,
+                             const struct dvb_usb_device_properties *props);
 
 extern int dvb_usb_device_power_ctrl(struct dvb_usb_device *d, int onoff);
 
index 42c207a..0fb3fa6 100644 (file)
@@ -84,7 +84,8 @@ int usb_cypress_load_firmware(struct usb_device *udev, const struct firmware *fw
 }
 EXPORT_SYMBOL(usb_cypress_load_firmware);
 
-int dvb_usb_download_firmware(struct usb_device *udev, struct dvb_usb_device_properties *props)
+int dvb_usb_download_firmware(struct usb_device *udev,
+                             const struct dvb_usb_device_properties *props)
 {
        int ret;
        const struct firmware *fw = NULL;
index 46ada09..c1a7634 100644 (file)
@@ -184,10 +184,10 @@ static int dvb_usb_init(struct dvb_usb_device *d, short *adapter_nums)
 }
 
 /* determine the name and the state of the just found USB device */
-static struct dvb_usb_device_description *dvb_usb_find_device(struct usb_device *udev, struct dvb_usb_device_properties *props, int *cold)
+static const struct dvb_usb_device_description *dvb_usb_find_device(struct usb_device *udev, const struct dvb_usb_device_properties *props, int *cold)
 {
        int i, j;
-       struct dvb_usb_device_description *desc = NULL;
+       const struct dvb_usb_device_description *desc = NULL;
 
        *cold = -1;
 
@@ -242,13 +242,13 @@ int dvb_usb_device_power_ctrl(struct dvb_usb_device *d, int onoff)
  * USB
  */
 int dvb_usb_device_init(struct usb_interface *intf,
-                       struct dvb_usb_device_properties *props,
+                       const struct dvb_usb_device_properties *props,
                        struct module *owner, struct dvb_usb_device **du,
                        short *adapter_nums)
 {
        struct usb_device *udev = interface_to_usbdev(intf);
        struct dvb_usb_device *d = NULL;
-       struct dvb_usb_device_description *desc = NULL;
+       const struct dvb_usb_device_description *desc = NULL;
 
        int ret = -ENOMEM, cold = 0;
 
index 2eb0e24..741be0e 100644 (file)
@@ -291,8 +291,10 @@ struct dvb_usb_device_properties {
 
        int (*power_ctrl)       (struct dvb_usb_device *, int);
        int (*read_mac_address) (struct dvb_usb_device *, u8 []);
-       int (*identify_state)   (struct usb_device *, struct dvb_usb_device_properties *,
-                       struct dvb_usb_device_description **, int *);
+       int (*identify_state)(struct usb_device *udev,
+                             const struct dvb_usb_device_properties *props,
+                             const struct dvb_usb_device_description **desc,
+                             int *cold);
 
        struct {
                enum dvb_usb_mode mode; /* Drivers shouldn't touch on it */
@@ -436,7 +438,7 @@ struct dvb_usb_adapter {
  */
 struct dvb_usb_device {
        struct dvb_usb_device_properties props;
-       struct dvb_usb_device_description *desc;
+       const struct dvb_usb_device_description *desc;
 
        struct usb_device *udev;
 
@@ -473,7 +475,7 @@ struct dvb_usb_device {
 };
 
 extern int dvb_usb_device_init(struct usb_interface *,
-                              struct dvb_usb_device_properties *,
+                              const struct dvb_usb_device_properties *,
                               struct module *, struct dvb_usb_device **,
                               short *adapter_nums);
 extern void dvb_usb_device_exit(struct usb_interface *);
index 594a763..f6d2d23 100644 (file)
@@ -955,8 +955,8 @@ static int su3000_read_mac_address(struct dvb_usb_device *d, u8 mac[6])
 }
 
 static int su3000_identify_state(struct usb_device *udev,
-                                struct dvb_usb_device_properties *props,
-                                struct dvb_usb_device_description **desc,
+                                const struct dvb_usb_device_properties *props,
+                                const struct dvb_usb_device_description **desc,
                                 int *cold)
 {
        info("%s", __func__);
index b8b99be..4bb5b82 100644 (file)
@@ -459,8 +459,8 @@ static int m920x_firmware_download(struct usb_device *udev, const struct firmwar
 
 /* Callbacks for DVB USB */
 static int m920x_identify_state(struct usb_device *udev,
-                               struct dvb_usb_device_properties *props,
-                               struct dvb_usb_device_description **desc,
+                               const struct dvb_usb_device_properties *props,
+                               const struct dvb_usb_device_description **desc,
                                int *cold)
 {
        struct usb_host_interface *alt;
index 676d233..f172120 100644 (file)
@@ -330,8 +330,8 @@ schedule:
 
 /* method to find out whether the firmware has to be downloaded or not */
 static int technisat_usb2_identify_state(struct usb_device *udev,
-               struct dvb_usb_device_properties *props,
-               struct dvb_usb_device_description **desc, int *cold)
+               const struct dvb_usb_device_properties *props,
+               const struct dvb_usb_device_description **desc, int *cold)
 {
        int ret;
        u8 *version;
index fd3e731..294274f 100644 (file)
@@ -467,9 +467,10 @@ static int tt3650_rc_query(struct dvb_usb_device *d)
 
 
 /* Callbacks for DVB USB */
-static int ttusb2_identify_state (struct usb_device *udev, struct
-               dvb_usb_device_properties *props, struct dvb_usb_device_description **desc,
-               int *cold)
+static int ttusb2_identify_state(struct usb_device *udev,
+                                const struct dvb_usb_device_properties *props,
+                                const struct dvb_usb_device_description **desc,
+                                int *cold)
 {
        *cold = udev->descriptor.iManufacturer == 0 && udev->descriptor.iProduct == 0;
        return 0;