tty: serial: fsl_lpuart: Drop no-op bit opearation
authorAndrey Smirnov <andrew.smirnov@gmail.com>
Mon, 29 Jul 2019 19:52:12 +0000 (12:52 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 Sep 2019 10:43:47 +0000 (12:43 +0200)
The check for termios->c_cflag & CRTSCTS ensure that if we reach else
branch, CRTSCTS in termios->c_cflag is already going to be
cleard. Doing so explicitly there is not necessary. Drop it.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Stefan Agner <stefan@agner.ch>
Cc: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
Cc: Chris Healy <cphealy@gmail.com>
Cc: Cory Tusar <cory.tusar@zii.aero>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>
Cc: linux-imx@nxp.com
Cc: linux-serial@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Link: https://lore.kernel.org/r/20190729195226.8862-11-andrew.smirnov@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/fsl_lpuart.c

index ed6d3f8..b3cc445 100644 (file)
@@ -1650,12 +1650,10 @@ lpuart_set_termios(struct uart_port *port, struct ktermios *termios,
        if (sport->port.rs485.flags & SER_RS485_ENABLED)
                termios->c_cflag &= ~CRTSCTS;
 
-       if (termios->c_cflag & CRTSCTS) {
+       if (termios->c_cflag & CRTSCTS)
                modem |= (UARTMODEM_RXRTSE | UARTMODEM_TXCTSE);
-       } else {
-               termios->c_cflag &= ~CRTSCTS;
+       else
                modem &= ~(UARTMODEM_RXRTSE | UARTMODEM_TXCTSE);
-       }
 
        if (termios->c_cflag & CSTOPB)
                termios->c_cflag &= ~CSTOPB;