tls: do not call SNICallback unless present

When asynchronously parsing ClientHello for session resumption -
SNICallback may not be set. Check if it is present before invoking
it.

fix #7010

diff --git a/lib/_tls_wrap.js b/lib/_tls_wrap.js
index 92a649b..941bc70 100644 (file)
--- a/lib/_tls_wrap.js
+++ b/lib/_tls_wrap.js
@@ -104,7 +104,9 @@ function onclienthello(hello) {
     //   session.
     //
     // Therefore we should account session loading when dealing with servername
-    if (ret && ret.servername) {
+    if (!self._SNICallback) {
+      self.ssl.endParser();
+    } else if (ret && ret.servername) {
       self._SNICallback(ret.servername, onSNIResult);
     } else if (hello.servername && self._SNICallback) {
       self._SNICallback(hello.servername, onSNIResult);

diff --git a/test/simple/test-tls-session-cache.js b/test/simple/test-tls-session-cache.js
index a60ff94..d5db30c 100644 (file)
--- a/test/simple/test-tls-session-cache.js
+++ b/test/simple/test-tls-session-cache.js
@@ -90,6 +90,7 @@ function doTest(testOptions, callback) {
       's_client',
       '-tls1',
       '-connect', 'localhost:' + common.PORT,
+      '-servername', 'ohgod',
       '-key', join(common.fixturesDir, 'agent.key'),
       '-cert', join(common.fixturesDir, 'agent.crt'),
       '-reconnect'