projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
8c4863c
)
ASoC: codecs: wcd938x: fix uninitialized symbol warnings
author
Srinivas Kandagatla
<srinivas.kandagatla@linaro.org>
Mon, 21 Jun 2021 13:45:02 +0000
(14:45 +0100)
committer
Mark Brown
<broonie@kernel.org>
Tue, 22 Jun 2021 11:47:13 +0000
(12:47 +0100)
This patch fixes below two uninitialized symbol warnings
warning:
sound/soc/codecs/wcd938x.c:2092 wcd938x_tx_swr_ctrl()
error: uninitialized symbol 'rate'
sound/soc/codecs/wcd938x.c:2189 wcd938x_tx_channel_config()
error: uninitialized symbol 'reg'.
First one my brining in check to already existing if condition and
second one by adding a default switch case to avoid any access to reg.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link:
https://lore.kernel.org/r/20210621134502.19537-2-srinivas.kandagatla@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wcd938x.c
patch
|
blob
|
history
diff --git
a/sound/soc/codecs/wcd938x.c
b/sound/soc/codecs/wcd938x.c
index
aac854e
..
78b76ec
100644
(file)
--- a/
sound/soc/codecs/wcd938x.c
+++ b/
sound/soc/codecs/wcd938x.c
@@
-2085,11
+2085,9
@@
static int wcd938x_tx_swr_ctrl(struct snd_soc_dapm_widget *w,
}
rate = wcd938x_get_clk_rate(i);
wcd938x_set_swr_clk_rate(component, rate, bank);
- }
-
- if (strnstr(w->name, "ADC", sizeof("ADC")))
/* Copy clk settings to active bank */
wcd938x_set_swr_clk_rate(component, rate, !bank);
+ }
break;
case SND_SOC_DAPM_POST_PMD:
if (strnstr(w->name, "ADC", sizeof("ADC"))) {
@@
-2184,6
+2182,8
@@
static void wcd938x_tx_channel_config(struct snd_soc_component *component,
reg = WCD938X_ANA_TX_CH4;
mask = WCD938X_HPF4_INIT_MASK;
break;
+ default:
+ return;
}
snd_soc_component_write_field(component, reg, mask, mode);