efl_ui_slack: remove explicit animation removings
authorMarcel Hollerbach <mail@marcel-hollerbach.de>
Sat, 23 Feb 2019 10:05:18 +0000 (11:05 +0100)
committerWonki Kim <wonki_.kim@samsung.com>
Fri, 8 Mar 2019 11:49:35 +0000 (20:49 +0900)
it appears that this is a bit unnessesery. Setting an animator to NULL
only causes the animation to be stopped. However, in all cases of these
removed calls, a new animator is setted anyways in one of the next
calls. Which means, the old animator is going to be stopped and removed
anyways. Thus these calls are unnessesery

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D8007

src/lib/elementary/efl_ui_stack.c

index b2138764c411395fffb6d5b09c43bf5e7ab2ea76..e4e4ed364a7f048f96d3b3c6c5f0ffb57c1f98b3 100644 (file)
@@ -280,10 +280,6 @@ _efl_ui_stack_push(Eo *obj, Efl_Ui_Stack_Data *pd, Eo *content)
          * the content without animation. */
         if (top_cd->on_pushing)
           {
-             //Finish current animation.
-             efl_canvas_object_event_animation_set(top_content,
-                                                   EFL_GFX_ENTITY_EVENT_SHOW, NULL);
-
              _hide_content_without_anim(obj, top_content);
              _announce_hiding(obj, top_content);
           }
@@ -337,10 +333,6 @@ _efl_ui_stack_pop(Eo *obj, Efl_Ui_Stack_Data *pd)
          * the content without animation. */
         if (top_cd->on_popping)
           {
-             //Finish current animation.
-             efl_canvas_object_event_animation_set(top_content,
-                                                   EFL_GFX_ENTITY_EVENT_SHOW, NULL);
-
              _hide_content_without_anim(obj, top_content);
              _announce_hiding(obj, top_content);
           }
@@ -362,13 +354,6 @@ _efl_ui_stack_pop(Eo *obj, Efl_Ui_Stack_Data *pd)
                                                           Content_Data);
         Eo *prev_content = prev_cd->content;
 
-        //If content is being pushed now, then finish current animation.
-        if (prev_cd->on_pushing)
-          {
-             efl_canvas_object_event_animation_set(prev_content,
-                                                   EFL_GFX_ENTITY_EVENT_HIDE,
-                                                   NULL);
-          }
         prev_cd->on_popping = EINA_TRUE;
 
         //Loaded Event