e_client: change wl_signal_emit_mutable to wl_signal_emit

For avoid crashes in multh thread environment using "get_below" and other similar functions that using signal,
have been chagned from "wl_signal_emit_mutable" to "wl_signal_emit".

NOTE: This patch is aims to avoid a critical section issue with the signal listener list of "wl_signal_emit_mutable"
we needs fundamental solution for it.

Change-Id: I3f26c7246064dc781a1f8226fce2ce233f888cd3

diff --git a/src/bin/e_client.c b/src/bin/e_client.c
index 7d45b87..e2daf59 100644 (file)
--- a/src/bin/e_client.c
+++ b/src/bin/e_client.c
@@ -1219,7 +1219,7 @@ _e_client_move_begin(E_Client *ec)
    ec->moving = 1;
    ecmove = ec;
 
-   wl_signal_emit_mutable(&PRI(ec)->events.move_begin, NULL);
+   wl_signal_emit(&PRI(ec)->events.move_begin, NULL);
    _e_client_hook_call(E_CLIENT_HOOK_MOVE_BEGIN, ec);
    if (!ec->moving)
      {
@@ -1245,7 +1245,7 @@ _e_client_move_end(E_Client *ec)
    ec->moving = 0;
    _e_client_action_input_win_del();
 
-   wl_signal_emit_mutable(&PRI(ec)->events.move_end, NULL);
+   wl_signal_emit(&PRI(ec)->events.move_end, NULL);
    _e_client_hook_call(E_CLIENT_HOOK_MOVE_END, ec);
 
    if (ec->transformed)
@@ -1652,7 +1652,7 @@ _e_client_resize_end(E_Client *ec)
    ec->resize_mode = E_POINTER_RESIZE_NONE;
    _e_client_action_input_win_del();
 
-   wl_signal_emit_mutable(&PRI(ec)->events.move_resize_end, NULL);
+   wl_signal_emit(&PRI(ec)->events.move_resize_end, NULL);
    _e_client_hook_call(E_CLIENT_HOOK_RESIZE_END, ec);
 
    if (ec->transformed)
@@ -2055,7 +2055,7 @@ _e_client_cb_evas_move(void *data, Evas *e EINA_UNUSED, Evas_Object *obj EINA_UN
      }
    if (ec->moving || (ecmove == ec))
      {
-        wl_signal_emit_mutable(&PRI(ec)->events.move_resize_update, NULL);
+        wl_signal_emit(&PRI(ec)->events.move_resize_update, NULL);
         _e_client_hook_call(E_CLIENT_HOOK_MOVE_UPDATE, ec);
      }
 
@@ -2068,7 +2068,7 @@ _e_client_cb_evas_move(void *data, Evas *e EINA_UNUSED, Evas_Object *obj EINA_UN
 
    ec->pre_cb.x = x; ec->pre_cb.y = y;
 
-   wl_signal_emit_mutable(&PRI(ec)->events.move, NULL);
+   wl_signal_emit(&PRI(ec)->events.move, NULL);
 
    e_comp_visibility_calculation_set(EINA_TRUE);
 }
@@ -2110,7 +2110,7 @@ _e_client_cb_evas_resize(void *data, Evas *e EINA_UNUSED, Evas_Object *obj EINA_
 
    if (e_client_util_resizing_get(ec) || (ecresize == ec))
      {
-         wl_signal_emit_mutable(&PRI(ec)->events.move_resize_update, NULL);
+         wl_signal_emit(&PRI(ec)->events.move_resize_update, NULL);
         _e_client_hook_call(E_CLIENT_HOOK_RESIZE_UPDATE, ec);
      }
    ec->pre_cb.w = w; ec->pre_cb.h = h;
@@ -2204,7 +2204,7 @@ _e_client_aux_hint_eval(E_Client *ec)
 
    if (cdata && cdata->aux_hint.changed)
      {
-        wl_signal_emit_mutable(&PRI(ec)->events.aux_hint_change, NULL);
+        wl_signal_emit(&PRI(ec)->events.aux_hint_change, NULL);
         _e_client_hook_call(E_CLIENT_HOOK_AUX_HINT_CHANGE, ec);
 
         EINA_LIST_FOREACH_SAFE(cdata->aux_hint.hints, l, ll, hint)
@@ -2239,7 +2239,7 @@ _e_client_eval(E_Client *ec)
 
    TRACE_DS_BEGIN(CLIENT:EVAL);
 
-   wl_signal_emit_mutable(&PRI(ec)->events.eval_pre_new_client, NULL);
+   wl_signal_emit(&PRI(ec)->events.eval_pre_new_client, NULL);
    if (!_e_client_hook_call(E_CLIENT_HOOK_EVAL_PRE_NEW_CLIENT, ec))
      {
         TRACE_DS_END();
@@ -2248,7 +2248,7 @@ _e_client_eval(E_Client *ec)
 
    if ((ec->new_client) && (!e_client_util_ignored_get(ec)))
      {
-        wl_signal_emit_mutable(&PRI(ec)->events.eval_post_new_client, NULL);
+        wl_signal_emit(&PRI(ec)->events.eval_post_new_client, NULL);
         if (!_e_client_hook_call(E_CLIENT_HOOK_EVAL_POST_NEW_CLIENT, ec))
           {
              TRACE_DS_END();
@@ -2383,7 +2383,7 @@ _e_client_eval(E_Client *ec)
 
    e_client_transform_core_update(ec);
 
-   wl_signal_emit_mutable(&PRI(ec)->events.eval_end, NULL);
+   wl_signal_emit(&PRI(ec)->events.eval_end, NULL);
    _e_client_hook_call(E_CLIENT_HOOK_EVAL_END, ec);
 
    TRACE_DS_END();
@@ -2632,7 +2632,7 @@ e_client_visibility_change_notify(E_Client *ec)
    if (ec->visibility.changed)
      _e_client_event_simple(ec, E_EVENT_CLIENT_VISIBILITY_CHANGE);
 
-   wl_signal_emit_mutable(&PRI(ec)->events.eval_visibility, NULL);
+   wl_signal_emit(&PRI(ec)->events.eval_visibility, NULL);
    _e_client_hook_call(E_CLIENT_HOOK_EVAL_VISIBILITY, ec);
 }
 
@@ -3027,12 +3027,12 @@ e_client_idler_before(Eina_Bool *check_focus)
         // call hooks to decide what to do - maybe move/resize
         if (ec->ignored || (!ec->changed)) continue;
 
-        wl_signal_emit_mutable(&PRI(ec)->events.eval_pre_fetch, NULL);
+        wl_signal_emit(&PRI(ec)->events.eval_pre_fetch, NULL);
         if (!_e_client_hook_call(E_CLIENT_HOOK_EVAL_PRE_FETCH, ec)) continue;
 
 
         /* FETCH is hooked by the compositor to get client hints */
-        wl_signal_emit_mutable(&PRI(ec)->events.eval_fetch, NULL);
+        wl_signal_emit(&PRI(ec)->events.eval_fetch, NULL);
         if (!_e_client_hook_call(E_CLIENT_HOOK_EVAL_FETCH, ec)) continue;
 
         if (ec->new_client)
@@ -3041,14 +3041,14 @@ e_client_idler_before(Eina_Bool *check_focus)
           }
 
         /* PRE_POST_FETCH calls e_remember apply for new client */
-        wl_signal_emit_mutable(&PRI(ec)->events.eval_pre_post_fetch, NULL);
+        wl_signal_emit(&PRI(ec)->events.eval_pre_post_fetch, NULL);
         if (!_e_client_hook_call(E_CLIENT_HOOK_EVAL_PRE_POST_FETCH, ec)) continue;
-        wl_signal_emit_mutable(&PRI(ec)->events.eval_post_fetch, NULL);
+        wl_signal_emit(&PRI(ec)->events.eval_post_fetch, NULL);
         if (!_e_client_hook_call(E_CLIENT_HOOK_EVAL_POST_FETCH, ec)) continue;
-        wl_signal_emit_mutable(&PRI(ec)->events.eval_pre_frame_assign, NULL);
+        wl_signal_emit(&PRI(ec)->events.eval_pre_frame_assign, NULL);
         if (!_e_client_hook_call(E_CLIENT_HOOK_EVAL_PRE_FRAME_ASSIGN, ec)) continue;
 
-        wl_signal_emit_mutable(&PRI(ec)->events.eval_post_frame_assign, NULL);
+        wl_signal_emit(&PRI(ec)->events.eval_post_frame_assign, NULL);
         _e_client_hook_call(E_CLIENT_HOOK_EVAL_POST_FRAME_ASSIGN, ec);
      }
    // pass 2 - show and hide windows needing hide and eval (main eval)
@@ -3277,7 +3277,7 @@ e_client_new(E_Pixmap *cp, int first_map, int internal)
 
    e_client_iconified_type_set(ec, E_ICONIFIED_TYPE_NONE);
 
-   wl_signal_emit_mutable(&PRI(ec)->events.new_client, NULL);
+   wl_signal_emit(&PRI(ec)->events.new_client, NULL);
    if (!_e_client_hook_call(E_CLIENT_HOOK_NEW_CLIENT, ec))
      {
         /* delete the above allocated object */
@@ -3338,7 +3338,7 @@ e_client_new(E_Pixmap *cp, int first_map, int internal)
         evas_object_event_callback_add(ec->frame, EVAS_CALLBACK_RESTACK, _e_client_cb_evas_restack, ec);
      }
 
-   wl_signal_emit_mutable(&PRI(ec)->events.new_client_post, NULL);
+   wl_signal_emit(&PRI(ec)->events.new_client_post, NULL);
 
 #ifdef _F_E_CLIENT_NEW_CLIENT_POST_HOOK_
    _e_client_hook_call(E_CLIENT_HOOK_NEW_CLIENT_POST, ec);
@@ -3404,7 +3404,7 @@ e_client_mouse_in(E_Client *ec, int x, int y)
    ec->mouse.current.my = y;
    ec->mouse.in = 1;
 
-   wl_signal_emit_mutable(&PRI(ec)->events.mouse_in, NULL);
+   wl_signal_emit(&PRI(ec)->events.mouse_in, NULL);
 }
 
 EINTERN void
@@ -3422,7 +3422,7 @@ e_client_mouse_out(E_Client *ec, int x, int y)
    ec->mouse.current.my = y;
    ec->mouse.in = 0;
 
-   wl_signal_emit_mutable(&PRI(ec)->events.mouse_out, NULL);
+   wl_signal_emit(&PRI(ec)->events.mouse_out, NULL);
 }
 
 EINTERN void
@@ -3477,7 +3477,7 @@ e_client_mouse_down(E_Client *ec, int button, Evas_Point *output, E_Binding_Even
    ec->mouse.current.mx = output->x;
    ec->mouse.current.my = output->y;
 
-   wl_signal_emit_mutable(&PRI(ec)->events.mouse_down, NULL);
+   wl_signal_emit(&PRI(ec)->events.mouse_down, NULL);
 }
 
 EINTERN void
@@ -3750,7 +3750,7 @@ e_client_above_get(const E_Client *ec)
 
    data.above_ec = NULL;
 
-   wl_signal_emit_mutable(&priv->events.get_above, &data);
+   wl_signal_emit(&priv->events.get_above, &data);
 
    return data.above_ec;
 #else
@@ -3810,7 +3810,7 @@ e_client_below_get(const E_Client *ec)
 
    data.below_ec = NULL;
 
-   wl_signal_emit_mutable(&priv->events.get_below, &data);
+   wl_signal_emit(&priv->events.get_below, &data);
 
    return data.below_ec;
 #else
@@ -3897,7 +3897,7 @@ e_client_visible_above_get(E_Client *ec)
 
    data.above_ec = NULL;
 
-   wl_signal_emit_mutable(&priv->events.get_visible_above, &data);
+   wl_signal_emit(&priv->events.get_visible_above, &data);
 
    return data.above_ec;
 #else
@@ -3950,7 +3950,7 @@ e_client_visible_below_get(E_Client *ec)
 
    data.below_ec = NULL;
 
-   wl_signal_emit_mutable(&priv->events.get_visible_below, &data);
+   wl_signal_emit(&priv->events.get_visible_below, &data);
 
    return data.below_ec;
 #else
@@ -4168,7 +4168,7 @@ e_client_focus_latest_set(E_Client *ec)
 {
    EINA_SAFETY_ON_NULL_RETURN(ec);
 
-   wl_signal_emit_mutable(&PRI(ec)->events.focus_latest_set, NULL);
+   wl_signal_emit(&PRI(ec)->events.focus_latest_set, NULL);
 }
 
 E_API void
@@ -4176,7 +4176,7 @@ e_client_focus_defer_set(E_Client *ec)
 {
    EINA_SAFETY_ON_NULL_RETURN(ec);
 
-   wl_signal_emit_mutable(&PRI(ec)->events.focus_defer_set, NULL);
+   wl_signal_emit(&PRI(ec)->events.focus_defer_set, NULL);
 }
 
 EINTERN void
@@ -4202,7 +4202,7 @@ e_client_focused_set(E_Client *ec)
          {
             // FIXME: Remove focus_unset event of client.
             //        Instead, make zone focus_unset event and use it.
-            wl_signal_emit_mutable(&PRI(focused_ec)->events.focus_unset, NULL);
+            wl_signal_emit(&PRI(focused_ec)->events.focus_unset, NULL);
             _e_client_hook_call(E_CLIENT_HOOK_FOCUS_UNSET, focused_ec);
 
             if (e_object_ref_get(E_OBJECT(focused_ec)) > 0)
@@ -4224,7 +4224,7 @@ e_client_focused_set(E_Client *ec)
    // FIXME: Remove focus_set event of client.
    //        Instead, make zone focus_set event and use it.
    // set the new current focused_ec
-   wl_signal_emit_mutable(&PRI(ec)->events.focus_set, NULL);
+   wl_signal_emit(&PRI(ec)->events.focus_set, NULL);
    _e_client_hook_call(E_CLIENT_HOOK_FOCUS_SET, ec);
 
    // send the client_focuse_in event
@@ -4255,7 +4255,7 @@ e_client_activate(E_Client *ec)
    ec->exp_iconify.by_client = 0;
    e_client_iconified_type_set(ec, E_ICONIFIED_TYPE_NONE);
 
-   wl_signal_emit_mutable(&PRI(ec)->events.activate_done, NULL);
+   wl_signal_emit(&PRI(ec)->events.activate_done, NULL);
    _e_client_hook_call(E_CLIENT_HOOK_ACTIVATE_DONE, ec);
 
    TRACE_DS_END();
@@ -4362,7 +4362,7 @@ e_client_maximize(E_Client *ec, E_Maximize max)
    if (!ec->fullscreen)
      {
         // call the maximize hook of a client
-        wl_signal_emit_mutable(&PRI(ec)->events.maximize, &max);
+        wl_signal_emit(&PRI(ec)->events.maximize, &max);
 
         // store the E_Maximize value
         ec->maximized = max;
@@ -4406,7 +4406,7 @@ e_client_unmaximize(E_Client *ec, E_Maximize max)
         evas_object_smart_callback_call(ec->frame, "unmaximize_pre", NULL);
 
         // call the unmaximize hook of a client
-        wl_signal_emit_mutable(&PRI(ec)->events.unmaximize, &max);
+        wl_signal_emit(&PRI(ec)->events.unmaximize, &max);
 
         evas_object_smart_callback_call(ec->frame, "unmaximize_done", NULL);
      }
@@ -4424,7 +4424,7 @@ e_client_fullscreen(E_Client *ec, E_Fullscreen policy)
    if (ec->fullscreen) return;
 
    // call the fullscreen_pre hook of a client
-   wl_signal_emit_mutable(&PRI(ec)->events.fullscreen_pre, NULL);
+   wl_signal_emit(&PRI(ec)->events.fullscreen_pre, NULL);
    _e_client_hook_call(E_CLIENT_HOOK_FULLSCREEN_PRE, ec);
 
    if (ec->skip_fullscreen) return;
@@ -4440,7 +4440,7 @@ e_client_fullscreen(E_Client *ec, E_Fullscreen policy)
    ec->fullscreen = 1;
 
    // call the fullscreen hook of a client
-   wl_signal_emit_mutable(&PRI(ec)->events.fullscreen, &policy);
+   wl_signal_emit(&PRI(ec)->events.fullscreen, &policy);
 
    ec->fullscreen_policy = policy;
 
@@ -4462,7 +4462,7 @@ e_client_unfullscreen(E_Client *ec)
    E_Fullscreen policy = ec->fullscreen_policy;
 
    // call the unfullscreen hook of a client
-   wl_signal_emit_mutable(&PRI(ec)->events.unfullscreen, &policy);
+   wl_signal_emit(&PRI(ec)->events.unfullscreen, &policy);
 
    e_client_layer_set(ec, ec->saved.layer);
 
@@ -4516,7 +4516,7 @@ e_client_iconify(E_Client *ec)
 
    TRACE_DS_BEGIN(CLIENT:ICONIFY);
 
-   wl_signal_emit_mutable(&PRI(ec)->events.iconify, NULL);
+   wl_signal_emit(&PRI(ec)->events.iconify, NULL);
    _e_client_hook_call(E_CLIENT_HOOK_ICONIFY, ec);
 
    TRACE_DS_END();
@@ -4542,7 +4542,7 @@ e_client_uniconify(E_Client *ec)
    TRACE_DS_BEGIN(CLIENT:UNICONIFY);
 
     // call the uniconify hook of a client
-   wl_signal_emit_mutable(&PRI(ec)->events.uniconify, NULL);
+   wl_signal_emit(&PRI(ec)->events.uniconify, NULL);
    _e_client_hook_call(E_CLIENT_HOOK_UNICONIFY, ec);
 
    TRACE_DS_END();
@@ -4620,7 +4620,7 @@ e_client_stick(E_Client *ec)
    if (ec->sticky) return;
 
    // call the stick hook of a client
-   wl_signal_emit_mutable(&PRI(ec)->events.stick, NULL);
+   wl_signal_emit(&PRI(ec)->events.stick, NULL);
 
    // send the sticky property event of a client
    _e_client_event_property(ec, E_CLIENT_PROPERTY_STICKY);
@@ -4635,7 +4635,7 @@ e_client_unstick(E_Client *ec)
    if (!ec->sticky) return;
 
    // call the unstick hook of a client
-   wl_signal_emit_mutable(&PRI(ec)->events.unstick, NULL);
+   wl_signal_emit(&PRI(ec)->events.unstick, NULL);
 
   // send the sticky property event of a client
    _e_client_event_property(ec, E_CLIENT_PROPERTY_STICKY);
@@ -4686,7 +4686,7 @@ e_client_act_move_keyboard(E_Client *ec)
    _e_client_action_init(ec);
    _e_client_action_move_timeout_add();
 
-   wl_signal_emit_mutable(&PRI(ec)->events.move_update, NULL);
+   wl_signal_emit(&PRI(ec)->events.move_update, NULL);
    if (!_e_client_hook_call(E_CLIENT_HOOK_MOVE_UPDATE, ec)) return;
    evas_object_freeze_events_set(ec->frame, 1);
 
@@ -4933,7 +4933,7 @@ e_client_resize_begin(E_Client *ec)
         ec->manage_resize.ah = ec->h - ec->manage_resize.header_h - ec->manage_resize.footer_h;
      }
 
-   wl_signal_emit_mutable(&PRI(ec)->events.move_begin, NULL);
+   wl_signal_emit(&PRI(ec)->events.move_begin, NULL);
    _e_client_hook_call(E_CLIENT_HOOK_RESIZE_BEGIN, ec);
    if (ec->transformed)
      _e_client_transform_resize_begin(ec);
@@ -5137,12 +5137,12 @@ e_client_redirected_set(E_Client *ec, Eina_Bool set)
      {
         e_client_frame_recalc(ec);
 
-        wl_signal_emit_mutable(&PRI(ec)->events.redirect, NULL);
+        wl_signal_emit(&PRI(ec)->events.redirect, NULL);
         if (!_e_client_hook_call(E_CLIENT_HOOK_REDIRECT, ec)) return;
      }
    else
      {
-        wl_signal_emit_mutable(&PRI(ec)->events.unredirect, NULL);
+        wl_signal_emit(&PRI(ec)->events.unredirect, NULL);
         if (!_e_client_hook_call(E_CLIENT_HOOK_UNREDIRECT, ec)) return;
      }
    e_comp_object_redirected_set(ec->frame, set);
@@ -5419,7 +5419,7 @@ e_client_transform_core_update(E_Client *ec)
 
         if (!e_object_is_del(E_OBJECT(ec)))
           {
-             wl_signal_emit_mutable(&PRI(ec)->events.transform_change, NULL);
+             wl_signal_emit(&PRI(ec)->events.transform_change, NULL);
              _e_client_hook_call(E_CLIENT_HOOK_TRANSFORM_CHANGE, ec);
           }
      }
@@ -5436,7 +5436,7 @@ e_client_transform_core_update(E_Client *ec)
 
              if (!e_object_is_del(E_OBJECT(ec)))
                {
-                  wl_signal_emit_mutable(&PRI(ec)->events.transform_change, NULL);
+                  wl_signal_emit(&PRI(ec)->events.transform_change, NULL);
                   _e_client_hook_call(E_CLIENT_HOOK_TRANSFORM_CHANGE, ec);
                }
           }
@@ -5556,7 +5556,7 @@ e_client_window_role_set(E_Client *ec, const char *role)
 
    if (eina_stringshare_replace(&ec->icccm.window_role, role))
      {
-        wl_signal_emit_mutable(&PRI(ec)->events.window_role_change, NULL);
+        wl_signal_emit(&PRI(ec)->events.window_role_change, NULL);
         _e_client_hook_call(E_CLIENT_HOOK_WINDOW_ROLE_CHANGE, ec);
      }
 }
@@ -6163,7 +6163,7 @@ e_client_layer_set(E_Client *ec,
           }
      }
 
-   wl_signal_emit_mutable(&PRI(ec)->events.set_layer, NULL);
+   wl_signal_emit(&PRI(ec)->events.set_layer, NULL);
 
    return EINA_TRUE;
 }
@@ -6383,7 +6383,7 @@ e_client_raise(E_Client *ec)
    else
      evas_object_raise(ec->frame);
 
-   wl_signal_emit_mutable(&PRI(ec)->events.raise, NULL);
+   wl_signal_emit(&PRI(ec)->events.raise, NULL);
 }
 
 static void
@@ -6497,7 +6497,7 @@ e_client_lower(E_Client *ec)
           {
              e_desk_area_ec_lower(eda, ec);
 
-             wl_signal_emit_mutable(&PRI(ec)->events.lower, NULL);
+             wl_signal_emit(&PRI(ec)->events.lower, NULL);
              return;
           }
      }
@@ -6508,7 +6508,7 @@ e_client_lower(E_Client *ec)
    else
      evas_object_lower(ec->frame);
 
-   wl_signal_emit_mutable(&PRI(ec)->events.lower, NULL);
+   wl_signal_emit(&PRI(ec)->events.lower, NULL);
 }
 
 E_API void
@@ -6535,7 +6535,7 @@ e_client_stack_above(E_Client *ec, E_Client *above)
 
    evas_object_stack_above(ec->frame, above->frame);
 
-   wl_signal_emit_mutable(&PRI(ec)->events.stack_above, NULL);
+   wl_signal_emit(&PRI(ec)->events.stack_above, NULL);
 }
 
 E_API void
@@ -6562,7 +6562,7 @@ e_client_stack_below(E_Client *ec, E_Client *below)
 
    evas_object_stack_below(ec->frame, below->frame);
 
-   wl_signal_emit_mutable(&PRI(ec)->events.stack_below, NULL);
+   wl_signal_emit(&PRI(ec)->events.stack_below, NULL);
 }
 
 E_API int
@@ -6917,7 +6917,7 @@ e_client_stack_transient_for_done_notify(E_Client *ec)
 {
    EINA_SAFETY_ON_NULL_RETURN(ec);
 
-   wl_signal_emit_mutable(&PRI(ec)->events.stack_transient_for_done, NULL);
+   wl_signal_emit(&PRI(ec)->events.stack_transient_for_done, NULL);
 }
 
 #ifdef REFACTOR_DESK_AREA
@@ -6926,7 +6926,7 @@ e_client_subsurface_stack_update(E_Client *ec)
 {
    EINA_SAFETY_ON_NULL_RETURN(ec);
 
-   wl_signal_emit_mutable(&PRI(ec)->events.subsurface_stack_update, ec);
+   wl_signal_emit(&PRI(ec)->events.subsurface_stack_update, ec);
 }
 #endif