Fix email API storage.

Email API writes to same file irrespective of handle.
If two processes from same app, try to write to same file, simultaneously, it could corrupt the contents.
This patch uses mkstemp() API to create temporary file names.

Change-Id: I31460f65d20b5a8707d8684ca279bdc0c54d5acb

diff --git a/src/email.c b/src/email.c
index f09d1cb03163de93d3b520c534f1a1c49b175706..3b8082b7fe06e7bfcfaa02ff8662cd83a554ab3b 100755 (executable)
--- a/src/email.c
+++ b/src/email.c
@@ -140,10 +140,12 @@ int email_create_message(email_h *msg)
        msg_s->mail->full_address_from = (char *)calloc(1, sizeof(char) * (len));/* "++"+<+ address +> + NULL */
        char *strfrom = msg_s->mail->full_address_from;
 
-       if (account->incoming_server_user_name)
-               snprintf(strfrom, len, "%s%s%s%s%s%s", "\"", account->incoming_server_user_name, "\"", "<", account->user_email_address, ">");
-       else
-               snprintf(strfrom, len, "%s%s%s", "<", account->user_email_address, ">");
+       if (NULL != strfrom) {
+               if (account->incoming_server_user_name)
+                       snprintf(strfrom, len, "%s%s%s%s%s%s", "\"", account->incoming_server_user_name, "\"", "<", account->user_email_address, ">");
+               else
+                       snprintf(strfrom, len, "%s%s%s", "<", account->user_email_address, ">");
+       }
 
        /* mbox */
        email_mailbox_t *mbox = msg_s->mbox;
@@ -259,7 +261,7 @@ int email_set_body(email_h msg, const char *body)
        }
        free(prefix_path);
 
-       file = fopen(file_path, "w");
+       file = fdopen(mkstemp(file_path), "w");
        if (NULL == file) {
                /* LCOV_EXCL_START */
                SECURE_SLOGE("fopen() Fail(%d)", EMAILS_ERROR_OPERATION_FAILED);
@@ -269,6 +271,7 @@ int email_set_body(email_h msg, const char *body)
 
        fputs(body, file);
        fclose(file);
+       unlink(file_path);
 
        msg_s->mail->file_path_plain = file_path;