ipv6: additional ref count for hash list unnecessary
authorstephen hemminger <shemminger@vyatta.com>
Mon, 12 Apr 2010 05:41:33 +0000 (05:41 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 13 Apr 2010 09:29:28 +0000 (02:29 -0700)
Since an address in hash list has to already have a ref count,
no additional ref count is needed.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/addrconf.c

index 9d78c12..a0175ed 100644 (file)
@@ -676,7 +676,6 @@ ipv6_add_addr(struct inet6_dev *idev, const struct in6_addr *addr, int pfxlen,
        hash = ipv6_addr_hash(addr);
 
        hlist_add_head_rcu(&ifa->addr_lst, &inet6_addr_lst[hash]);
-       in6_ifa_hold(ifa);
        spin_unlock(&addrconf_hash_lock);
 
        write_lock(&idev->lock);
@@ -724,7 +723,6 @@ static void ipv6_del_addr(struct inet6_ifaddr *ifp)
 
        spin_lock_bh(&addrconf_hash_lock);
        hlist_del_init_rcu(&ifp->addr_lst);
-       __in6_ifa_put(ifp);
        spin_unlock_bh(&addrconf_hash_lock);
 
        write_lock_bh(&idev->lock);
@@ -2713,7 +2711,6 @@ static int addrconf_ifdown(struct net_device *dev, int how)
                        /* clear hash table */
                        spin_lock_bh(&addrconf_hash_lock);
                        hlist_del_init_rcu(&ifa->addr_lst);
-                       __in6_ifa_put(ifa);
                        spin_unlock_bh(&addrconf_hash_lock);
                }