Differential Revision: https://reviews.llvm.org/D153064
UnsafeBufferUsageHandler &Handler,
bool EmitSuggestions) {
assert(D && D->getBody());
+
+ // Do not emit fixit suggestions for functions declared in an
+ // extern "C" block.
+ if (const auto *FD = dyn_cast<FunctionDecl>(D)) {
+ for (FunctionDecl *FReDecl : FD->redecls()) {
+ if (FReDecl->isExternC()) {
+ EmitSuggestions = false;
+ break;
+ }
+ }
+ }
+
WarningGadgetSets UnsafeOps;
FixableGadgetSets FixablesForAllVars;
--- /dev/null
+// RUN: %clang_cc1 -std=c++20 -Wunsafe-buffer-usage -fsafe-buffer-usage-suggestions -verify %s
+
+extern "C" {
+void foo(int *ptr) {
+ ptr[5] = 10; // expected-warning{{unsafe buffer access}}
+}
+
+void bar(int *ptr);
+
+struct c_struct {
+ char *name;
+};
+}
+
+void bar(int *ptr) {
+ ptr[5] = 10; // expected-warning{{unsafe buffer access}}
+}
+
+void call_foo(int *p) {
+ foo(p);
+ struct c_struct str;
+ str.name[7] = 9; // expected-warning{{unsafe buffer access}}
+ bar(p);
+}