[Title] Fix bug candidate in static analysis

[Type]      Enhancement
[Module]    Sub
[Priority]  Minor
[CQ#]       // CQ Issue Number
[Redmine#]  // Redmine Isuue Number
[Problem]   // Problem Description
[Cause]     // Cause Description
[Solution]  // Solution Description
[TestCase]  // Executed the test-target (How to)

diff --git a/org.tizen.common.connection/src/org/tizen/common/connection/explorer/ConnectionExplorerPanel.java b/org.tizen.common.connection/src/org/tizen/common/connection/explorer/ConnectionExplorerPanel.java
old mode 100644 (file)
new mode 100755 (executable)
index bab1c36..f5d9b46
--- a/org.tizen.common.connection/src/org/tizen/common/connection/explorer/ConnectionExplorerPanel.java
+++ b/org.tizen.common.connection/src/org/tizen/common/connection/explorer/ConnectionExplorerPanel.java
@@ -86,7 +86,6 @@ import org.tizen.common.ui.view.console.AnsicodeAdapter;
 import org.tizen.common.ui.view.console.ConsoleManager;
 import org.tizen.common.util.DialogUtil;
 import org.tizen.common.util.FilenameUtil;
-import org.tizen.common.util.OSChecker;
 import org.tizen.common.util.log.Logger;
 import org.tizen.sdblib.FileListingService.FileEntry;
 import org.tizen.sdblib.IDevice;
@@ -909,6 +908,8 @@ public class ConnectionExplorerPanel extends Panel implements IDeviceChangeListe
                             yesAll = true;
                         case IDialogConstants.YES_ID:
                             break;
+                        default:
+                            break;
                         }
                     }
                 }
@@ -1075,6 +1076,8 @@ public class ConnectionExplorerPanel extends Panel implements IDeviceChangeListe
                         return ConnectionUIMessages.Explorer_Message_Invalid_Character + FilenameUtil.getInvalidCharacters(os);
                     case FilenameUtil.HAS_NO_NAME:
                         return "";
+                    default:
+                        break;
                 }
             }
             return null;

diff --git a/org.tizen.common.connection/src/org/tizen/common/connection/properties/ConnectionExplorerPermissionPropertyPages.java b/org.tizen.common.connection/src/org/tizen/common/connection/properties/ConnectionExplorerPermissionPropertyPages.java
old mode 100644 (file)
new mode 100755 (executable)
index 538a411..f286a6f
--- a/org.tizen.common.connection/src/org/tizen/common/connection/properties/ConnectionExplorerPermissionPropertyPages.java
+++ b/org.tizen.common.connection/src/org/tizen/common/connection/properties/ConnectionExplorerPermissionPropertyPages.java
@@ -128,14 +128,10 @@ public class ConnectionExplorerPermissionPropertyPages extends PropertyPage {
                table.setHeaderVisible(true);
                table.setLinesVisible(true);
                
-               TableColumn colMsg = createTableColumn(table, "", SWT.NONE,
-               "EXECUTE");
-               colMsg = createTableColumn(table, "Read", SWT.NONE,
-               "EXECUTE");
-               colMsg = createTableColumn(table, "Write", SWT.NONE,
-               "EXECUTE");
-               colMsg = createTableColumn(table, "Execute", SWT.NONE,
-               "EXECUTE");
+               createTableColumn(table, "", SWT.NONE, "EXECUTE");
+               createTableColumn(table, "Read", SWT.NONE, "EXECUTE");
+               createTableColumn(table, "Write", SWT.NONE, "EXECUTE");
+               createTableColumn(table, "Execute", SWT.NONE, "EXECUTE");
                
                
                itemUser = new TableItem(table, SWT.NONE);

diff --git a/org.tizen.common.connection/src/org/tizen/common/connection/ui/ConnectionExplorer.java b/org.tizen.common.connection/src/org/tizen/common/connection/ui/ConnectionExplorer.java
old mode 100644 (file)
new mode 100755 (executable)
index a756a74..0b5f061
--- a/org.tizen.common.connection/src/org/tizen/common/connection/ui/ConnectionExplorer.java
+++ b/org.tizen.common.connection/src/org/tizen/common/connection/ui/ConnectionExplorer.java
@@ -388,7 +388,7 @@ public class ConnectionExplorer extends ViewPart
         toolBar = new ToolBar(shell, SWT.NULL);
         toolBar.setLayoutData(layoutData);
 
-        ToolItem item = new ToolItem(toolBar, SWT.SEPARATOR);
+        new ToolItem(toolBar, SWT.SEPARATOR);   // Separator
 
         emulManagerToolItem = new ToolItem(toolBar, SWT.PUSH);
         emulManagerToolItem.setImage(ConnectionPlugin.getImageDescriptorFromPlugin("icons/emulator_manager.gif").createImage());
@@ -409,7 +409,7 @@ public class ConnectionExplorer extends ViewPart
         });
         emulManagerToolItem.setEnabled(true);
 
-        item = new ToolItem(toolBar, SWT.SEPARATOR);
+        new ToolItem(toolBar, SWT.SEPARATOR);   // Separator
 
         pushToolItem = new ToolItem(toolBar, SWT.PUSH);
         pushToolItem.setImage(ConnectionPlugin.getImageDescriptorFromPlugin("icons/push.gif").createImage());
@@ -424,7 +424,7 @@ public class ConnectionExplorer extends ViewPart
         });
         pushToolItem.setEnabled(false);
 
-        item = new ToolItem(toolBar, SWT.SEPARATOR);
+        new ToolItem(toolBar, SWT.SEPARATOR);   // Separator
 
         pullToolItem = new ToolItem(toolBar, SWT.PUSH);
         pullToolItem.setImage(ConnectionPlugin.getImageDescriptorFromPlugin("icons/pull.gif").createImage());
@@ -438,7 +438,7 @@ public class ConnectionExplorer extends ViewPart
             }
         });
         pullToolItem.setEnabled(false);
-        item = new ToolItem(toolBar, SWT.SEPARATOR);
+        new ToolItem(toolBar, SWT.SEPARATOR);   // Separator
     }
 
     @Override
@@ -450,7 +450,7 @@ public class ConnectionExplorer extends ViewPart
     {
         String exePath = null;
         int osType = ConnectionPlugin.getDefault().os;
-        int linuxType = ConnectionPlugin.getDefault().LINUX;
+        int linuxType = ConnectionPlugin.LINUX;
 
         if (osType == linuxType)
         {

diff --git a/org.tizen.common.externals/src/org/mihalis/opal/columns/ColumnBrowserWidget.java b/org.tizen.common.externals/src/org/mihalis/opal/columns/ColumnBrowserWidget.java
old mode 100644 (file)
new mode 100755 (executable)
index b358121..991f6a2
--- a/org.tizen.common.externals/src/org/mihalis/opal/columns/ColumnBrowserWidget.java
+++ b/org.tizen.common.externals/src/org/mihalis/opal/columns/ColumnBrowserWidget.java
@@ -183,6 +183,8 @@ public class ColumnBrowserWidget extends ScrolledComposite {
                                        event.gc.drawImage(ColumnBrowserWidget.this.columnArrow, x, event.y + offset);\r
                                        break;\r
                                }\r
+                               default:\r
+                                   break;\r
                                }\r
                        }\r
                };\r

diff --git a/org.tizen.common.externals/src/org/mihalis/opal/multiChoice/MultiChoice.java b/org.tizen.common.externals/src/org/mihalis/opal/multiChoice/MultiChoice.java
old mode 100644 (file)
new mode 100755 (executable)
index bb0c2ac..43271e5
--- a/org.tizen.common.externals/src/org/mihalis/opal/multiChoice/MultiChoice.java
+++ b/org.tizen.common.externals/src/org/mihalis/opal/multiChoice/MultiChoice.java
@@ -1025,6 +1025,8 @@ public class MultiChoice<T> extends Composite {
                        notifyListeners(SWT.FocusOut, e);\r
                        break;\r
                }\r
+               default:\r
+                   break;\r
                }\r
        }\r
 \r
@@ -1054,6 +1056,8 @@ public class MultiChoice<T> extends Composite {
                                dropDown(false);\r
                        }\r
                        break;\r
+               default:\r
+                   break;\r
                }\r
 \r
        }\r
@@ -1073,6 +1077,8 @@ public class MultiChoice<T> extends Composite {
                        dropDown(!isDropped());\r
                        break;\r
                }\r
+               default:\r
+                   break;\r
                }\r
        }\r
 \r

diff --git a/org.tizen.common.externals/src/org/mihalis/opal/rangeSlider/RangeSlider.java b/org.tizen.common.externals/src/org/mihalis/opal/rangeSlider/RangeSlider.java
old mode 100644 (file)
new mode 100755 (executable)

diff --git a/org.tizen.common.externals/src/org/mihalis/opal/tipOfTheDay/TipOfTheDay.java b/org.tizen.common.externals/src/org/mihalis/opal/tipOfTheDay/TipOfTheDay.java
old mode 100644 (file)
new mode 100755 (executable)
index 8f58b7f..4ec53c7
--- a/org.tizen.common.externals/src/org/mihalis/opal/tipOfTheDay/TipOfTheDay.java
+++ b/org.tizen.common.externals/src/org/mihalis/opal/tipOfTheDay/TipOfTheDay.java
@@ -126,6 +126,8 @@ public class TipOfTheDay {
                                        event.detail = SWT.TRAVERSE_NONE;\r
                                        event.doit = false;\r
                                        break;\r
+                               default:\r
+                                   break;\r
                                }\r
                        }\r
                });\r

diff --git a/org.tizen.common/src/org/tizen/common/file/StandardFileHandler.java b/org.tizen.common/src/org/tizen/common/file/StandardFileHandler.java
old mode 100644 (file)
new mode 100755 (executable)
index 5820078..a0b852e
--- a/org.tizen.common/src/org/tizen/common/file/StandardFileHandler.java
+++ b/org.tizen.common/src/org/tizen/common/file/StandardFileHandler.java
@@ -35,10 +35,8 @@ import java.io.IOException;
 import java.io.InputStream;
 import java.util.ArrayList;
 import java.util.Collection;
-import java.util.Stack;
 
 import org.tizen.common.util.IOUtil;
-import org.tizen.common.util.log.Logger;
 
 /**
  * <p>