pinctrl: imxl: Fix an error handling path in 'imx1_pinctrl_core_probe()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sat, 30 May 2020 20:19:52 +0000 (22:19 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 24 Jun 2020 15:50:38 +0000 (17:50 +0200)
[ Upstream commit 9eb728321286c4b31e964d2377fca2368526d408 ]

When 'pinctrl_register()' has been turned into 'devm_pinctrl_register()',
an error handling path has not been updated.

Axe a now unneeded 'pinctrl_unregister()'.

Fixes: e55e025d1687 ("pinctrl: imxl: Use devm_pinctrl_register() for pinctrl registration")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/20200530201952.585798-1-christophe.jaillet@wanadoo.fr
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pinctrl/freescale/pinctrl-imx1-core.c

index 7e29e3f..5bb183c 100644 (file)
@@ -638,7 +638,6 @@ int imx1_pinctrl_core_probe(struct platform_device *pdev,
 
        ret = of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev);
        if (ret) {
-               pinctrl_unregister(ipctl->pctl);
                dev_err(&pdev->dev, "Failed to populate subdevices\n");
                return ret;
        }