arm64: dts: meson-axg: Make mmc host controller interrupts level-sensitive
authorHeiner Kallweit <hkallweit1@gmail.com>
Thu, 9 Feb 2023 20:10:31 +0000 (21:10 +0100)
committerNeil Armstrong <neil.armstrong@linaro.org>
Fri, 10 Feb 2023 08:02:09 +0000 (09:02 +0100)
The usage of edge-triggered interrupts lead to lost interrupts under load,
see [0]. This was confirmed to be fixed by using level-triggered
interrupts.
The report was about SDIO. However, as the host controller is the same
for SD and MMC, apply the change to all mmc controller instances.

[0] https://www.spinics.net/lists/linux-mmc/msg73991.html

Fixes: 221cf34bac54 ("ARM64: dts: meson-axg: enable the eMMC controller")
Reported-by: Peter Suti <peter.suti@streamunlimited.com>
Tested-by: Vyacheslav Bocharov <adeep@lexina.in>
Tested-by: Peter Suti <peter.suti@streamunlimited.com>
Cc: stable@vger.kernel.org
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Acked-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/c00655d3-02f8-6f5f-4239-ca2412420cad@gmail.com
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
arch/arm64/boot/dts/amlogic/meson-axg.dtsi

index 1648e67..417523d 100644 (file)
                        sd_emmc_b: sd@5000 {
                                compatible = "amlogic,meson-axg-mmc";
                                reg = <0x0 0x5000 0x0 0x800>;
-                               interrupts = <GIC_SPI 217 IRQ_TYPE_EDGE_RISING>;
+                               interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>;
                                status = "disabled";
                                clocks = <&clkc CLKID_SD_EMMC_B>,
                                        <&clkc CLKID_SD_EMMC_B_CLK0>,
                        sd_emmc_c: mmc@7000 {
                                compatible = "amlogic,meson-axg-mmc";
                                reg = <0x0 0x7000 0x0 0x800>;
-                               interrupts = <GIC_SPI 218 IRQ_TYPE_EDGE_RISING>;
+                               interrupts = <GIC_SPI 218 IRQ_TYPE_LEVEL_HIGH>;
                                status = "disabled";
                                clocks = <&clkc CLKID_SD_EMMC_C>,
                                        <&clkc CLKID_SD_EMMC_C_CLK0>,