NFSD: Replace READ* macros in nfsd4_decode_access()
authorChuck Lever <chuck.lever@oracle.com>
Tue, 3 Nov 2020 18:12:27 +0000 (13:12 -0500)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 30 Nov 2020 19:46:36 +0000 (14:46 -0500)
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4xdr.c

index e3a2912..b0d3a21 100644 (file)
@@ -439,17 +439,6 @@ nfsd4_decode_stateid(struct nfsd4_compoundargs *argp, stateid_t *sid)
        DECODE_TAIL;
 }
 
-static __be32
-nfsd4_decode_access(struct nfsd4_compoundargs *argp, struct nfsd4_access *access)
-{
-       DECODE_HEAD;
-
-       READ_BUF(4);
-       access->ac_req_access = be32_to_cpup(p++);
-
-       DECODE_TAIL;
-}
-
 static __be32 nfsd4_decode_cb_sec(struct nfsd4_compoundargs *argp, struct nfsd4_cb_sec *cbs)
 {
        DECODE_HEAD;
@@ -531,6 +520,19 @@ static __be32 nfsd4_decode_cb_sec(struct nfsd4_compoundargs *argp, struct nfsd4_
        DECODE_TAIL;
 }
 
+/*
+ * NFSv4 operation argument decoders
+ */
+
+static __be32
+nfsd4_decode_access(struct nfsd4_compoundargs *argp,
+                   struct nfsd4_access *access)
+{
+       if (xdr_stream_decode_u32(argp->xdr, &access->ac_req_access) < 0)
+               return nfserr_bad_xdr;
+       return nfs_ok;
+}
+
 static __be32 nfsd4_decode_backchannel_ctl(struct nfsd4_compoundargs *argp, struct nfsd4_backchannel_ctl *bc)
 {
        DECODE_HEAD;