v4l2codecs: h264: Add missing break
authorNicolas Dufresne <nicolas.dufresne@collabora.com>
Wed, 20 May 2020 11:35:28 +0000 (07:35 -0400)
committerGStreamer Merge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Thu, 21 May 2020 20:12:07 +0000 (20:12 +0000)
There was a missing break for the 4:4:4 case which would break the sizeimage
calculation. We don't currently have hardware that supports 4:4:4, so this
code wasn't tested. This was detected by Coverity.

CID 1463592 1463591

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1283>

sys/v4l2codecs/gstv4l2codech264dec.c

index 29f96d4..0fa96dd 100644 (file)
@@ -211,6 +211,7 @@ get_pixel_bitdepth (GstV4l2CodecH264Dec * self)
     case 3:
       /* 4:4:4 */
       depth = 3 * self->bitdepth;
+      break;
     default:
       GST_WARNING_OBJECT (self, "Unsupported chroma format %i",
           self->chroma_format_idc);