[libc++] Fix tests for the runtime assertions in <barrier>
authorEdoardo Sanguineti <edoardo.sanguineti222@gmail.com>
Thu, 20 Jul 2023 08:14:07 +0000 (08:14 +0000)
committerDavid Spickett <david.spickett@linaro.org>
Thu, 20 Jul 2023 08:15:02 +0000 (08:15 +0000)
As @ldionne pointed out to me in a newer revision, there is a //REQUIRE comment in both files edited by this patch that prevents the test to run on some platforms where it should actually run.

Reviewed By: #libc, ldionne

Differential Revision: https://reviews.llvm.org/D155755

libcxx/test/libcxx/thread/thread.barrier/assert.arrive.pass.cpp
libcxx/test/libcxx/thread/thread.barrier/assert.ctor.pass.cpp

index e36f8bc..b0ee1c2 100644 (file)
@@ -7,12 +7,11 @@
 //===----------------------------------------------------------------------===//
 // UNSUPPORTED: no-threads
 // UNSUPPORTED: c++03, c++11, c++14, c++17
+// UNSUPPORTED: !libcpp-has-hardened-mode && !libcpp-has-debug-mode
 
-// REQUIRES: availability-synchronization_library-missing
-// XFAIL: target={{.+}}-apple-macosx10.{{13|15}}
+// XFAIL: availability-verbose_abort-missing
 
 // REQUIRES: has-unix-headers
-// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_ENABLE_ASSERTIONS=1
 
 // <barrier>
 
index 10641eb..161fb72 100644 (file)
@@ -7,12 +7,11 @@
 //===----------------------------------------------------------------------===//
 // UNSUPPORTED: no-threads
 // UNSUPPORTED: c++03, c++11, c++14, c++17
+// UNSUPPORTED: !libcpp-has-hardened-mode && !libcpp-has-debug-mode
 
-// REQUIRES: availability-synchronization_library-missing
-// XFAIL: target={{.+}}-apple-macosx10.{{13|15}}
+// XFAIL: availability-verbose_abort-missing
 
 // REQUIRES: has-unix-headers
-// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_ENABLE_ASSERTIONS=1
 
 // <barrier>