media: atomisp: pci: fix error return code in atomisp_pci_probe()
authorYang Yingliang <yangyingliang@huawei.com>
Thu, 17 Jun 2021 07:23:29 +0000 (09:23 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 22 Jul 2021 12:01:56 +0000 (14:01 +0200)
If init_atomisp_wdts() fails, atomisp_pci_probe() need return
error code.

Link: https://lore.kernel.org/linux-media/20210617072329.1233662-1-yangyingliang@huawei.com
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/atomisp/pci/atomisp_v4l2.c

index af0d83eaa68c27ade3c115732bb618333e5e3a53..1e324f1f656e56744be92ba05a16e67f6df9dcfc 100644 (file)
@@ -1763,7 +1763,8 @@ static int atomisp_pci_probe(struct pci_dev *pdev, const struct pci_device_id *i
        if (err < 0)
                goto register_entities_fail;
        /* init atomisp wdts */
-       if (init_atomisp_wdts(isp) != 0)
+       err = init_atomisp_wdts(isp);
+       if (err != 0)
                goto wdt_work_queue_fail;
 
        /* save the iunit context only once after all the values are init'ed. */