tools: kwboot: Change retry loop from decreasing to increasing
authorPali Rohár <pali@kernel.org>
Mon, 25 Oct 2021 13:13:03 +0000 (15:13 +0200)
committerStefan Roese <sr@denx.de>
Wed, 3 Nov 2021 05:45:27 +0000 (06:45 +0100)
This patch does not change behavior of the code, just allows to implement
new changes more easily.

Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Marek Behún <marek.behun@nic.cz>
Reviewed-by: Stefan Roese <sr@denx.de>
tools/kwboot.c

index 5d7cb7a..16c5a84 100644 (file)
@@ -925,7 +925,7 @@ kwboot_xm_sendblock(int fd, struct kwboot_block *block, int allow_non_xm,
 
        *done_print = 0;
 
-       retries = 16;
+       retries = 0;
        do {
                rc = kwboot_tty_send(fd, block, sizeof(*block));
                if (rc)
@@ -944,7 +944,7 @@ kwboot_xm_sendblock(int fd, struct kwboot_block *block, int allow_non_xm,
 
                if (!allow_non_xm && c != ACK)
                        kwboot_progress(-1, '+');
-       } while (c == NAK && retries-- > 0);
+       } while (c == NAK && retries++ < 16);
 
        if (non_xm_print)
                kwboot_printv("\n");
@@ -973,7 +973,7 @@ kwboot_xm_finish(int fd)
 
        kwboot_printv("Finishing transfer\n");
 
-       retries = 16;
+       retries = 0;
        do {
                rc = kwboot_tty_send_char(fd, EOT);
                if (rc)
@@ -982,7 +982,7 @@ kwboot_xm_finish(int fd)
                rc = kwboot_xm_recv_reply(fd, &c, 0, NULL, 0, NULL);
                if (rc)
                        return rc;
-       } while (c == NAK && retries-- > 0);
+       } while (c == NAK && retries++ < 16);
 
        return _xm_reply_to_error(c);
 }